You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/03/31 09:11:35 UTC
Review Request 19835: Refactored State::names to return a set instead of
vector.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19835/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/java/jni/org_apache_mesos_state_AbstractState.cpp 476bb27dc5a17f78fc5c5beb2b2f33eec5d055a2
src/state/in_memory.hpp 822a89a5ff053c080ef03e6c7f097a8e1070008f
src/state/in_memory.cpp b18456502e4a1cccdb8476aa2c1edf2a0323338a
src/state/leveldb.hpp f2d6d27ce41bcfedeebb63af647add270a79dc56
src/state/leveldb.cpp 6db3ecf4fcec891fd562094a14810c06047aeac4
src/state/state.hpp bebfe02dcdcbaec8742d173e2233817288722bd8
src/state/storage.hpp a13707553d12e624751ac030de3f991f5bb7732d
src/state/zookeeper.hpp 420315b9e1906e0e277717c90f0d5b2f92fdbad4
src/state/zookeeper.cpp dd632c0b2a746a87f8f827ff191f31143e80b130
src/tests/state_tests.cpp d0e084070c566ee7d751a8e1279772e05b966145
Diff: https://reviews.apache.org/r/19835/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 19835: Refactored State::names to return a set instead of
vector.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19835/#review39707
-----------------------------------------------------------
Ship it!
Good to see this!
- Ben Mahler
On March 31, 2014, 7:11 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19835/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 7:11 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 476bb27dc5a17f78fc5c5beb2b2f33eec5d055a2
> src/state/in_memory.hpp 822a89a5ff053c080ef03e6c7f097a8e1070008f
> src/state/in_memory.cpp b18456502e4a1cccdb8476aa2c1edf2a0323338a
> src/state/leveldb.hpp f2d6d27ce41bcfedeebb63af647add270a79dc56
> src/state/leveldb.cpp 6db3ecf4fcec891fd562094a14810c06047aeac4
> src/state/state.hpp bebfe02dcdcbaec8742d173e2233817288722bd8
> src/state/storage.hpp a13707553d12e624751ac030de3f991f5bb7732d
> src/state/zookeeper.hpp 420315b9e1906e0e277717c90f0d5b2f92fdbad4
> src/state/zookeeper.cpp dd632c0b2a746a87f8f827ff191f31143e80b130
> src/tests/state_tests.cpp d0e084070c566ee7d751a8e1279772e05b966145
>
> Diff: https://reviews.apache.org/r/19835/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 19835: Refactored State::names to return a set instead of
vector.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19835/#review39168
-----------------------------------------------------------
Ship it!
src/tests/state_tests.cpp
<https://reviews.apache.org/r/19835/#comment71528>
using std::set;
using std::string;
- Jie Yu
On March 31, 2014, 7:11 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19835/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 7:11 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 476bb27dc5a17f78fc5c5beb2b2f33eec5d055a2
> src/state/in_memory.hpp 822a89a5ff053c080ef03e6c7f097a8e1070008f
> src/state/in_memory.cpp b18456502e4a1cccdb8476aa2c1edf2a0323338a
> src/state/leveldb.hpp f2d6d27ce41bcfedeebb63af647add270a79dc56
> src/state/leveldb.cpp 6db3ecf4fcec891fd562094a14810c06047aeac4
> src/state/state.hpp bebfe02dcdcbaec8742d173e2233817288722bd8
> src/state/storage.hpp a13707553d12e624751ac030de3f991f5bb7732d
> src/state/zookeeper.hpp 420315b9e1906e0e277717c90f0d5b2f92fdbad4
> src/state/zookeeper.cpp dd632c0b2a746a87f8f827ff191f31143e80b130
> src/tests/state_tests.cpp d0e084070c566ee7d751a8e1279772e05b966145
>
> Diff: https://reviews.apache.org/r/19835/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>