[GitHub] [ozone] lokeshj1703 commented on a change in pull request #2578: HDDS-5671. ContainerBalancer#stop interrupts the balancing thread before letting it join.

[GitBox <gi...@apache.org>]

lokeshj1703 commented on a change in pull request #2578:
URL: https://github.com/apache/ozone/pull/2578#discussion_r697292681



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -722,8 +722,8 @@ public void stop() {
         return;
       }
       balancerRunning = false;
+      currentBalancingThread.join(500);

Review comment:
       join is a waiting call. This will return when the thread stops or after timeout of 500ms.
   The existing logic seems good. Interrupt is required to get the thread out of wait state so that close can finish faster.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org