You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/07 09:33:50 UTC

[GitHub] [airflow] lokeshlal commented on a change in pull request #6975: [AIRFLOW-1467] Dynamic pooling via allowing tasks to use more than one pool slot (depending upon the need)

lokeshlal commented on a change in pull request #6975: [AIRFLOW-1467] Dynamic pooling via allowing tasks to use more than one pool slot (depending upon the need)
URL: https://github.com/apache/airflow/pull/6975#discussion_r363661435
 
 

 ##########
 File path: airflow/models/baseoperator.py
 ##########
 @@ -309,6 +311,7 @@ def __init__(
         weight_rule: str = WeightRule.DOWNSTREAM,
         queue: str = conf.get('celery', 'default_queue'),
         pool: str = Pool.DEFAULT_POOL_NAME,
+        pool_capacity: int = 1,
 
 Review comment:
   Yes, it is correct. pool_capacity should never be less than 1. I will put a check in taskinstance __init__ for pool_capacity value to be >= 1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services