You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/20 01:38:51 UTC
[GitHub] [hudi] yihua opened a new pull request, #7713: [HUDI-5589] Fix Hudi config inference
yihua opened a new pull request, #7713:
URL: https://github.com/apache/hudi/pull/7713
### Change Logs
For a config defined by `ConfigProperty` with no default value set, e.g., `DynamoDbBasedLockConfig.DYNAMODB_LOCK_PARTITION_KEY`, even if the inference function is set with `.withInferFunction()`, the inference function is not invoked to generate the config value. This PR fixes the issue so that such a config can still get the inferred value without default value set.
### Impact
Correct the config inference. This fixes these two existing configs: `hoodie.write.lock.dynamodb.partition_key` (`DynamoDbBasedLockConfig.DYNAMODB_LOCK_PARTITION_KEY`) and `hoodie.write.lock.zookeeper.lock_key` (`HoodieLockConfig.ZK_LOCK_KEY`). This also makes the proper inference for `hoodie.write.concurrency.early.conflict.detection.strategy` in #6133.
### Risk level
low
### Documentation Update
N/A
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1398825374
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14482",
"triggerID" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a55175d7d5bfdddd775ed16ccac6d859ce6619c6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14482)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1397908288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478",
"triggerID" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"triggerType" : "PUSH"
}, {
"hash" : "4ef51f2e03159eda252b15f90993069d257923f6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ef51f2e03159eda252b15f90993069d257923f6",
"triggerType" : "PUSH"
}, {
"hash" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 198a828b76b654e4b8f3ef8ac133f672a682cdf8 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478)
* 4ef51f2e03159eda252b15f90993069d257923f6 UNKNOWN
* a55175d7d5bfdddd775ed16ccac6d859ce6619c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1397862421
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 198a828b76b654e4b8f3ef8ac133f672a682cdf8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #7713:
URL: https://github.com/apache/hudi/pull/7713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1397911609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478",
"triggerID" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"triggerType" : "PUSH"
}, {
"hash" : "4ef51f2e03159eda252b15f90993069d257923f6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ef51f2e03159eda252b15f90993069d257923f6",
"triggerType" : "PUSH"
}, {
"hash" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14482",
"triggerID" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 198a828b76b654e4b8f3ef8ac133f672a682cdf8 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478)
* 4ef51f2e03159eda252b15f90993069d257923f6 UNKNOWN
* a55175d7d5bfdddd775ed16ccac6d859ce6619c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14482)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1398807518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a55175d7d5bfdddd775ed16ccac6d859ce6619c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1397865854
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478",
"triggerID" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 198a828b76b654e4b8f3ef8ac133f672a682cdf8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1398164784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478",
"triggerID" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"triggerType" : "PUSH"
}, {
"hash" : "4ef51f2e03159eda252b15f90993069d257923f6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ef51f2e03159eda252b15f90993069d257923f6",
"triggerType" : "PUSH"
}, {
"hash" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14482",
"triggerID" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ef51f2e03159eda252b15f90993069d257923f6 UNKNOWN
* a55175d7d5bfdddd775ed16ccac6d859ce6619c6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14482)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1397904015
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478",
"triggerID" : "198a828b76b654e4b8f3ef8ac133f672a682cdf8",
"triggerType" : "PUSH"
}, {
"hash" : "4ef51f2e03159eda252b15f90993069d257923f6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ef51f2e03159eda252b15f90993069d257923f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 198a828b76b654e4b8f3ef8ac133f672a682cdf8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14478)
* 4ef51f2e03159eda252b15f90993069d257923f6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7713: [HUDI-5589] Fix Hudi config inference
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7713:
URL: https://github.com/apache/hudi/pull/7713#issuecomment-1398816939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14482",
"triggerID" : "a55175d7d5bfdddd775ed16ccac6d859ce6619c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a55175d7d5bfdddd775ed16ccac6d859ce6619c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14482)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org