[GitHub] [incubator-druid] qutang1 edited a comment on issue #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter, InDimFilter

[GitBox <gi...@apache.org>]

qutang1 edited a comment on issue #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter, InDimFilter
URL: https://github.com/apache/incubator-druid/pull/8974#issuecomment-561465846
 
 
   1. In the line 58 of eclipse_formatting.xml, it should be changed to:
   `<setting id="org.eclipse.jdt.core.formatter.insert_new_line_before_catch_in_try_statement" value="insert"/>` instead of  "do not insert". By making this change, "catch" block will be alone on a line to in line with CI standard. Thus eclipse auto-formatting will be correct. I think the xml should be updated although I guess no one else than me is still using eclipse...
   2. I've fixed BoundDimFilter and InDimFilter in this PR, SelectorDimFilter's code structure is slightly different, I am not sure if I did it correctly. Since CI is green now, would you please review and approve this PR first? I will create another one to handle SelectorDimFilter .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org