[GitHub] [superset] michael-s-molina commented on pull request #13079: test(frontend): improves react-testing-library configuration

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #13079:
URL: https://github.com/apache/superset/pull/13079#issuecomment-781989152


   > Hi all, eslint-plugin-testing-library author here! Sorry for jumping into this out of the blue, but I saw this issue referred in one from our plugin.
   > 
   > > Another important point is that ESLint rules of eslint-plugin-testing-library are not currently working with the import of custom functions from a different library name.
   > > In our case the rules will not be applied when using import { render, screen } from 'spec/helpers/testing-library';
   > > If we use import { render, screen } from ‘@testing-library/react’; then ESLint works.
   > > They are aware of this issue and are already working on a fix in version 4.
   > 
   > I've seen you have this problem when re-exporting Testing Library utils from a custom module, which is a pretty common one from plugin users. [On this comment](https://github.com/testing-library/eslint-plugin-testing-library/issues/173#issuecomment-780519874) from couple of days ago you can find some info about how we addressed this. I'd be really interested into knowing if this would be enough for you, or you think you would need more options to cover this.
   > 
   > From what I saw on your comment I think our approach will cover your use case, but just in case.
   > 
   > Thanks!
   
   @Belco90 Thank you for the update! I was reviewing the thread and it seems that with this [comment](https://github.com/testing-library/eslint-plugin-testing-library/issues/173#issuecomment-780524507) we'll have everything we need to setup ESLint nicely in our project. Thanks for this great plugin! 🚀 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org