You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@roller.apache.org by Greg Huber <gr...@gmail.com> on 2011/09/20 21:26:16 UTC

whilst I remember.....

Shelan,

Sorry, whilst I remember, may also need the type code in the
WeblogPageCache & SiteWideCache generateKey(WeblogPageRequest
pageRequest) method to get the correct page when loading from the
cache.

ie
key.append("/type=").append(pageRequest.getType());


Cheers Greg.

Re: whilst I remember.....

Posted by Dave <sn...@gmail.com>.

Hi Greg,

That's a good idea. The name WeblogTemplateCode implies something that
is associated with a weblog, and that is not the case with the new
code. I introduced a new interface Template code with this hierarchy:

   TemplateCode - interface representing template code for one type of
device (e.g. standard, mobile)
        SharedThemeTemplateCode - template code for a shared weblog theme
        WeblogThemeTemplateCode - template code for theme associated
with a weblog

Have you been working with the new template system and developing any
mobile-ready themes?

Thanks,
Dave



On Thu, Nov 24, 2011 at 3:56 AM, Greg Huber <gr...@gmail.com> wrote:
> Dave,
>
> If you are looking at the code, and to be more sympathetic to the
> current design, it might be worth creating an interface for
> ThemeTemplateCode and have WeblogTemplateCode implement it.  Then
> create a SharedThemeTemplateCode which also also implements
> ThemeTemplateCode.  This way you keep WeblogTemplateCode out of
> org.apache.roller.weblogger.business.themes. package.  Bit of extra
> work mind!
>
> Cheers Greg
>
> On 20 November 2011 14:54, Dave <sn...@gmail.com> wrote:
>> Thanks Greg,
>>
>> I just made a fix for this in both of those page cache classes.
>>
>> - Dave
>>
>>
>>
>> On Tue, Sep 20, 2011 at 3:26 PM, Greg Huber <gr...@gmail.com> wrote:
>>> Shelan,
>>>
>>> Sorry, whilst I remember, may also need the type code in the
>>> WeblogPageCache & SiteWideCache generateKey(WeblogPageRequest
>>> pageRequest) method to get the correct page when loading from the
>>> cache.
>>>
>>> ie
>>> key.append("/type=").append(pageRequest.getType());
>>>
>>>
>>> Cheers Greg.
>>>
>>
>>
>>
>> --
>> Dave M. Johnson
>> Apache Roller PMC Chair
>> http://rollerweblogger.org/roller
>>
>



-- 
Dave M. Johnson
Apache Roller PMC Chair
http://rollerweblogger.org/roller

Re: whilst I remember.....

Posted by Greg Huber <gr...@gmail.com>.

Dave,

If you are looking at the code, and to be more sympathetic to the
current design, it might be worth creating an interface for
ThemeTemplateCode and have WeblogTemplateCode implement it.  Then
create a SharedThemeTemplateCode which also also implements
ThemeTemplateCode.  This way you keep WeblogTemplateCode out of
org.apache.roller.weblogger.business.themes. package.  Bit of extra
work mind!

Cheers Greg

On 20 November 2011 14:54, Dave <sn...@gmail.com> wrote:
> Thanks Greg,
>
> I just made a fix for this in both of those page cache classes.
>
> - Dave
>
>
>
> On Tue, Sep 20, 2011 at 3:26 PM, Greg Huber <gr...@gmail.com> wrote:
>> Shelan,
>>
>> Sorry, whilst I remember, may also need the type code in the
>> WeblogPageCache & SiteWideCache generateKey(WeblogPageRequest
>> pageRequest) method to get the correct page when loading from the
>> cache.
>>
>> ie
>> key.append("/type=").append(pageRequest.getType());
>>
>>
>> Cheers Greg.
>>
>
>
>
> --
> Dave M. Johnson
> Apache Roller PMC Chair
> http://rollerweblogger.org/roller
>

Re: whilst I remember.....

Posted by Dave <sn...@gmail.com>.

Thanks Greg,

I just made a fix for this in both of those page cache classes.

- Dave



On Tue, Sep 20, 2011 at 3:26 PM, Greg Huber <gr...@gmail.com> wrote:
> Shelan,
>
> Sorry, whilst I remember, may also need the type code in the
> WeblogPageCache & SiteWideCache generateKey(WeblogPageRequest
> pageRequest) method to get the correct page when loading from the
> cache.
>
> ie
> key.append("/type=").append(pageRequest.getType());
>
>
> Cheers Greg.
>



-- 
Dave M. Johnson
Apache Roller PMC Chair
http://rollerweblogger.org/roller