You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/02/26 11:42:52 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue #9521: Add more test cases for ShardingSphereRulesBuilder if implements ResourceAware

terrymanu opened a new issue #9521:
URL: https://github.com/apache/shardingsphere/issues/9521


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu closed issue #9521: Add more test cases for ShardingSphereRulesBuilder if implements ResourceAware

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #9521:
URL: https://github.com/apache/shardingsphere/issues/9521


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] songyuequan commented on issue #9521: Add more test cases for ShardingSphereRulesBuilder if implements ResourceAware

Posted by GitBox <gi...@apache.org>.
songyuequan commented on issue #9521:
URL: https://github.com/apache/shardingsphere/issues/9521#issuecomment-789552865


   @terrymanu hi~  ShardingSphereRulesBuilder  is  not the implements of  ResourceAware .  should I add test cases In  ShardingSphereRulesBuilder  to   test if  all of "ShardingSphereRulesBuilder"  implement ResourceAware?   I feel confused.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] yu199195 commented on issue #9521: Add more test cases for ShardingSphereRulesBuilder if implements ResourceAware

Posted by GitBox <gi...@apache.org>.
yu199195 commented on issue #9521:
URL: https://github.com/apache/shardingsphere/issues/9521#issuecomment-787755839


   @songyuequan welcome join us


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #9521: Add more test cases for ShardingSphereRulesBuilder if implements ResourceAware

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #9521:
URL: https://github.com/apache/shardingsphere/issues/9521#issuecomment-857652416


   Sorry, the class `ShardingSphereRulesBuilder` is refactored and pass the necessary parameter in the method signature.
   I just close this issue for expired reason.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] songyuequan commented on issue #9521: Add more test cases for ShardingSphereRulesBuilder if implements ResourceAware

Posted by GitBox <gi...@apache.org>.
songyuequan commented on issue #9521:
URL: https://github.com/apache/shardingsphere/issues/9521#issuecomment-787736100


   can I  take it please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org