You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/15 09:56:37 UTC
[GitHub] [flink] dannycranmer opened a new pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
dannycranmer opened a new pull request #18773:
URL: https://github.com/apache/flink/pull/18773
## What is the purpose of the change
Add support for `AsyncSink` to downscale with state. `AsyncSinkWriter` can be restored from multiple `BufferedRequestState`
## Brief change log
- `AsyncSinkWriter` now handles multiple `BufferedRequestState`
- Added defaults to test `AsyncSinkWriter` to reduce complexity of test (in separate commit)
## Verifying this change
This change added tests and can be verified as follows:
- `AsyncSinkWriterTest::testRestoreFromMultipleStates`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: yes (state serializer)
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? n/a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
}, {
"hash" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31626",
"triggerID" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"triggerType" : "PUSH"
}, {
"hash" : "5dd2e51844f1551535aed452e731d57ff6d3c3a9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31656",
"triggerID" : "5dd2e51844f1551535aed452e731d57ff6d3c3a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5dd2e51844f1551535aed452e731d57ff6d3c3a9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31656)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
}, {
"hash" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31626",
"triggerID" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"triggerType" : "PUSH"
}, {
"hash" : "5dd2e51844f1551535aed452e731d57ff6d3c3a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31656",
"triggerID" : "5dd2e51844f1551535aed452e731d57ff6d3c3a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 57c7c3fb468d75f8868aaed70cba67ade11fa515 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31626)
* 5dd2e51844f1551535aed452e731d57ff6d3c3a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31656)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
* 59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "449acd193cbafcaf3944d758472023fc6b43bdda",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "449acd193cbafcaf3944d758472023fc6b43bdda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
* 449acd193cbafcaf3944d758472023fc6b43bdda UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #18773:
URL: https://github.com/apache/flink/pull/18773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
* 59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040078938
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3acd4a4b567a7ffb7551f43ef162433107a0fc6d (Tue Feb 15 10:01:54 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
* 59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
}, {
"hash" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31626",
"triggerID" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"triggerType" : "PUSH"
}, {
"hash" : "5dd2e51844f1551535aed452e731d57ff6d3c3a9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5dd2e51844f1551535aed452e731d57ff6d3c3a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520)
* 57c7c3fb468d75f8868aaed70cba67ade11fa515 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31626)
* 5dd2e51844f1551535aed452e731d57ff6d3c3a9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "91895919393f0c2d6343c23e31a4cd04c09b8c8a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "91895919393f0c2d6343c23e31a4cd04c09b8c8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
* 91895919393f0c2d6343c23e31a4cd04c09b8c8a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18773:
URL: https://github.com/apache/flink/pull/18773#discussion_r806652615
##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTest.java
##########
@@ -63,13 +64,7 @@ public void before() {
private void performNormalWriteOfEightyRecordsToMock()
throws IOException, InterruptedException {
AsyncSinkWriterImpl sink =
- new AsyncSinkWriterImplBuilder()
Review comment:
These changes are applied in a separate commit, if they make the diff hard to read please look at commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "91895919393f0c2d6343c23e31a4cd04c09b8c8a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "91895919393f0c2d6343c23e31a4cd04c09b8c8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
* 91895919393f0c2d6343c23e31a4cd04c09b8c8a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
* 59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
}, {
"hash" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520)
* 57c7c3fb468d75f8868aaed70cba67ade11fa515 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3acd4a4b567a7ffb7551f43ef162433107a0fc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18773:
URL: https://github.com/apache/flink/pull/18773#discussion_r806652615
##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTest.java
##########
@@ -63,13 +64,7 @@ public void before() {
private void performNormalWriteOfEightyRecordsToMock()
throws IOException, InterruptedException {
AsyncSinkWriterImpl sink =
- new AsyncSinkWriterImplBuilder()
Review comment:
These changes are applied in a separate commit, if they make the diff hard to read please look at commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18773: [FLINK-26118][connectors/common] Add support for AsyncSink to downscale with state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18773:
URL: https://github.com/apache/flink/pull/18773#issuecomment-1040077336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31506",
"triggerID" : "3acd4a4b567a7ffb7551f43ef162433107a0fc6d",
"triggerType" : "PUSH"
}, {
"hash" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520",
"triggerID" : "59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8",
"triggerType" : "PUSH"
}, {
"hash" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31626",
"triggerID" : "57c7c3fb468d75f8868aaed70cba67ade11fa515",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c3f76ccfd14c0a92bddfe2d8a4a269b192a0f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31520)
* 57c7c3fb468d75f8868aaed70cba67ade11fa515 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31626)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org