You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/02/01 12:54:19 UTC
[GitHub] [camel-k] bouskaJ opened a new pull request #2969: [TEST] Add CliDownloadTest
bouskaJ opened a new pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#issuecomment-1049712476
@astefanutti @squakez All pipelines except the upgrade and the validate has passed.
I think that the upgrade does not work ATM and I am not sure what's wrong with the validate. Can you check it, restart CI or help me to identify what should be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#discussion_r796839288
##########
File path: e2e/support/test_support.go
##########
@@ -1220,6 +1221,18 @@ func CRDs() func() []metav1.APIResource {
}
}
+func ConsoleCLIDownload(name string) func() *consoleV1.ConsoleCLIDownload {
+ return func() *consoleV1.ConsoleCLIDownload {
Review comment:
The group must be registered at https://github.com/apache/camel-k/blob/8523a6d329e53618feb0a35ef85dfe50c1078b3f/e2e/support/test_support.go#L122.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#discussion_r797377627
##########
File path: e2e/support/test_support.go
##########
@@ -1220,6 +1221,18 @@ func CRDs() func() []metav1.APIResource {
}
}
+func ConsoleCLIDownload(name string) func() *consoleV1.ConsoleCLIDownload {
+ return func() *consoleV1.ConsoleCLIDownload {
Review comment:
OK, I realise I've been too quick. It's failing in the current OpenShift workflow, not because of the type registration, but because it's still OpenShift 3, that doesn't have the ConsoleCLIDownload resources.
So the test should probably also be skipped depending on the result of:
```go
ok, err := kubernetes.IsAPIResourceInstalled(c, "console.openshift.io/v1", reflect.TypeOf(console.ConsoleCLIDownload{}).Name())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#issuecomment-1049717468
> @astefanutti @squakez All pipelines except the upgrade and the validate has passed.
>
> I think that the upgrade does not work ATM and I am not sure what's wrong with the validate. Can you check it, restart CI or help me to identify what should be fixed?
Yeah, those are failing for other reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on a change in pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on a change in pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#discussion_r797321613
##########
File path: e2e/support/test_support.go
##########
@@ -1220,6 +1221,18 @@ func CRDs() func() []metav1.APIResource {
}
}
+func ConsoleCLIDownload(name string) func() *consoleV1.ConsoleCLIDownload {
+ return func() *consoleV1.ConsoleCLIDownload {
Review comment:
hmm, it was working locally. That's strange. Let me fix it..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#issuecomment-1026989970
@bouskaJ rerun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on a change in pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on a change in pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#discussion_r797391694
##########
File path: e2e/support/test_support.go
##########
@@ -1220,6 +1221,18 @@ func CRDs() func() []metav1.APIResource {
}
}
+func ConsoleCLIDownload(name string) func() *consoleV1.ConsoleCLIDownload {
+ return func() *consoleV1.ConsoleCLIDownload {
Review comment:
yes, I started investigating the OCP 3 API once it failed again. I hope it will work this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
squakez merged pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#issuecomment-1026989970
@bouskaJ rerun 🤞🏼.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#issuecomment-1026988937
Can you rerun the `openshift` workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2969: [TEST] Add CliDownloadTest
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2969:
URL: https://github.com/apache/camel-k/pull/2969#issuecomment-1038813817
It failed on the MasterTraitTest this time
```
== CONT TestMasterTrait
master_test.go:79:
Timed out after 30.003s.
Expected
<string>: exec java -cp
```
Can you rerun the Kubernetes workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org