You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by me...@apache.org on 2015/02/04 00:58:44 UTC

mesos git commit: Removed --checkpoint flag.

Repository: mesos
Updated Branches:
  refs/heads/master b22d7addb -> 2abd9c8ae


Removed --checkpoint flag.

Checkpointing has been enabled by default in the slave since 0.14,
remove the flag now because all slaves should checkpoint.

Removing checkpoint from slaves throughout the codebase will occur in
a series of following commits.

Review: https://reviews.apache.org/r/26275


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2abd9c8a
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2abd9c8a
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2abd9c8a

Branch: refs/heads/master
Commit: 2abd9c8aefc47ae22856ee1b2fc1787a70a8460b
Parents: b22d7ad
Author: Cody Maloney <co...@mesosphere.io>
Authored: Tue Feb 3 15:07:08 2015 -0800
Committer: Adam B <ad...@mesosphere.io>
Committed: Tue Feb 3 15:07:08 2015 -0800

----------------------------------------------------------------------
 src/slave/flags.hpp | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/2abd9c8a/src/slave/flags.hpp
----------------------------------------------------------------------
diff --git a/src/slave/flags.hpp b/src/slave/flags.hpp
index 0f6cc41..facf6d3 100644
--- a/src/slave/flags.hpp
+++ b/src/slave/flags.hpp
@@ -42,6 +42,7 @@ class Flags : public logging::Flags
 {
 public:
   Flags()
+    : checkpoint(true)
   {
     add(&Flags::hostname,
         "hostname",
@@ -169,16 +170,6 @@ public:
         "resource usage (e.g., 10secs, 1min, etc)",
         RESOURCE_MONITORING_INTERVAL);
 
-    // TODO(vinod): Consider killing this flag and always checkpoint.
-    add(&Flags::checkpoint,
-        "checkpoint",
-        "This flag is deprecated and will be removed in a future release.\n"
-        "Whether to checkpoint slave and frameworks information\n"
-        "to disk. This enables a restarted slave to recover\n"
-        "status updates and reconnect with (--recover=reconnect) or\n"
-        "kill (--recover=cleanup) old executors",
-        true);
-
     add(&Flags::recover,
         "recover",
         "Whether to recover status updates and reconnect with old executors.\n"
@@ -480,6 +471,8 @@ public:
   double gc_disk_headroom;
   Duration disk_watch_interval;
   Duration resource_monitoring_interval;
+  // TODO(cmaloney): Remove checkpoint variable entirely, fixing tests
+  // which depend upon it. See MESOS-444 for more details.
   bool checkpoint;
   std::string recover;
   Duration recovery_timeout;