You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/12/21 15:29:59 UTC
[GitHub] [hbase] saintstack commented on a change in pull request #957:
HBASE-23604: Clarify AsyncRegistry usage in the code.
saintstack commented on a change in pull request #957: HBASE-23604: Clarify AsyncRegistry usage in the code.
URL: https://github.com/apache/hbase/pull/957#discussion_r360654153
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
##########
@@ -257,7 +257,7 @@ NonceGenerator getNonceGenerator() {
CompletableFuture<MasterService.Interface> getMasterStub() {
return ConnectionUtils.getOrFetch(masterStub, masterStubMakeFuture, false, () -> {
CompletableFuture<MasterService.Interface> future = new CompletableFuture<>();
- addListener(registry.getMasterAddress(), (addr, error) -> {
+ addListener(registry.getActiveMaster(), (addr, error) -> {
Review comment:
This is good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services