[GitHub] [arrow] alamb commented on a change in pull request #9264: ARROW-11319: [Rust] [DataFusion] Improve test comparisons to record batch, remove test::format_batch

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #9264:
URL: https://github.com/apache/arrow/pull/9264#discussion_r560947936



##########
File path: rust/datafusion/src/test/mod.rs
##########
@@ -106,137 +106,7 @@ pub fn aggr_test_schema() -> SchemaRef {
     ]))
 }
 
-/// Format a batch as csv
-pub fn format_batch(batch: &RecordBatch) -> Vec<String> {

Review comment:
       format batch is similar, but not the same, as pretty_print
   
   The major difference is that it renders NULL values as `"NULL"` whereas the pretty printer renders them as an empty string `""`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org