You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/21 13:49:48 UTC

[GitHub] [skywalking-kubernetes] hanahmily commented on a change in pull request #21: modify role to clusterrole

hanahmily commented on a change in pull request #21: modify role to clusterrole
URL: https://github.com/apache/skywalking-kubernetes/pull/21#discussion_r337028000
 
 

 ##########
 File path: helm-chart/helm3/6.4.0/skywalking/templates/oap-deployment.yaml
 ##########
 @@ -91,6 +91,10 @@ spec:
               fieldPath: metadata.uid
         - name: SW_STORAGE
           value: elasticsearch
+        {{- if .Values.oap.envoy.als.enabled }}
 
 Review comment:
   why do you add a parameter to control an env variable? all items listed in `.Values.oap.env` will be added here. Take a look at line 100.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services