You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/17 07:02:26 UTC
[GitHub] [flink] wsry opened a new pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
wsry opened a new pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786
## What is the purpose of the change
There are three scenarios that may lead to redundant data available notifications for PipelinedSubpartition:
1. Add a new buffer after an event;
2. Finish the current subpartition;
3. Flush an event buffer.
This commit reduces these redundant data available notifications.
## Brief change log
- Reduce the data available notification mentioned above;
- Add new test to verify the change.
## Verifying this change
A new test is added to verify the change.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160850008",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66188949ff1646c298d32df7fe45c6745f771bc1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160850008) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160850008",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d34a27ea803c0203027ec4cc5fb751bb30d51bad Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160839179) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706)
* 66188949ff1646c298d32df7fe45c6745f771bc1 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160850008) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0fd4119b3171f384375c3cd683b850b80c42e77 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/160684486) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637)
* 539aab54392550e3fc872cfa70681e6593b1a46e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160699412) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 539aab54392550e3fc872cfa70681e6593b1a46e Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160699412) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410355482
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -434,15 +445,12 @@ public int getBuffersInBacklog() {
}
}
- private boolean shouldNotifyDataAvailable() {
- // Notify only when we added first finished buffer.
- return readView != null && !flushRequested && getNumberOfFinishedBuffers() == 1;
+ private boolean mayNotifyDataAvailable() {
Review comment:
`mayNotifyDataAvailable` seems fit for `void` return type. I prefer to previous `shouldNotifyDataAvailable` which more fits for `boolean` return type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410368414
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -434,15 +445,12 @@ public int getBuffersInBacklog() {
}
}
- private boolean shouldNotifyDataAvailable() {
- // Notify only when we added first finished buffer.
- return readView != null && !flushRequested && getNumberOfFinishedBuffers() == 1;
+ private boolean mayNotifyDataAvailable() {
+ return readView != null && !dataAvailableNotified;
}
private void notifyDataAvailable() {
Review comment:
Refer to https://github.com/apache/flink/pull/11786/files#r410367542, we can keep this method to add the `dataAvailableNotified = true` inside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0fd4119b3171f384375c3cd683b850b80c42e77 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160684486) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637)
* 539aab54392550e3fc872cfa70681e6593b1a46e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160850008",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66188949ff1646c298d32df7fe45c6745f771bc1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160850008) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714)
* ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 539aab54392550e3fc872cfa70681e6593b1a46e Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160699412) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649)
* d34a27ea803c0203027ec4cc5fb751bb30d51bad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 539aab54392550e3fc872cfa70681e6593b1a46e Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160699412) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11786: [FLINK-17208][network]
Reduce redundant data available notifications of PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615081252
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6dd9add717d5f3f4af68d959afe09ec9c14668b4 (Fri Apr 17 07:06:00 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410367850
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -367,8 +377,9 @@ public void flush() {
}
// if there is more then 1 buffer, we already notified the reader
// (at the latest when adding the second buffer)
- notifyDataAvailable = !flushRequested && buffers.size() == 1 && buffers.peek().isDataAvailable();
+ notifyDataAvailable = mayNotifyDataAvailable() && buffers.peekFirst().isDataAvailable();
flushRequested = flushRequested || buffers.size() > 1 || notifyDataAvailable;
+ dataAvailableNotified = dataAvailableNotified || notifyDataAvailable;
Review comment:
Refer to https://github.com/apache/flink/pull/11786/files#r410367542, we can remove `dataAvailableNotified = dataAvailableNotified || notifyDataAvailable;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0fd4119b3171f384375c3cd683b850b80c42e77 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/160684486) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637)
* 539aab54392550e3fc872cfa70681e6593b1a46e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160699412) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160850008",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160877666",
"triggerID" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"triggerType" : "PUSH"
}, {
"hash" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7719",
"triggerID" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66188949ff1646c298d32df7fe45c6745f771bc1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160850008) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714)
* ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160877666) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7719)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410368726
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -307,6 +316,7 @@ public PipelinedSubpartitionView createReadView(BufferAvailabilityListener avail
readView = new PipelinedSubpartitionView(this, availabilityListener);
notifyDataAvailable = !buffers.isEmpty();
+ dataAvailableNotified = notifyDataAvailable;
Review comment:
Refer to https://github.com/apache/flink/pull/11786/files#r410367542, we can remove `dataAvailableNotified = notifyDataAvailable;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0fd4119b3171f384375c3cd683b850b80c42e77 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160684486) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410363733
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -79,6 +79,9 @@
@GuardedBy("buffers")
private boolean flushRequested;
+ @GuardedBy("buffers")
+ private boolean dataAvailableNotified = false;
Review comment:
nit: can remove `= false`, the default value is also false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410357221
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -252,16 +258,19 @@ BufferAndBacklog pollBuffer() {
}
if (buffer == null) {
+ dataAvailableNotified = false;
Review comment:
I guess the path of `buffer == null` was caused by duplicated notification for `LocalInputChannel`. If we already fixed the duplicated notification in this PR, can we remove this path for simple?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410374050
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -367,8 +377,9 @@ public void flush() {
}
// if there is more then 1 buffer, we already notified the reader
// (at the latest when adding the second buffer)
- notifyDataAvailable = !flushRequested && buffers.size() == 1 && buffers.peek().isDataAvailable();
+ notifyDataAvailable = mayNotifyDataAvailable() && buffers.peekFirst().isDataAvailable();
flushRequested = flushRequested || buffers.size() > 1 || notifyDataAvailable;
Review comment:
it would change the behavior of `flushRequested` here. The `flushRequested` is mainly used for judging the availability of partition called by upper component, so it should not be coupled with the condition of `dataAvailableNotified`.
E.g. if `flushRequested = false` and `buffers.size() == 1` and `buffers.peek().isDataAvailable()`, no matter with `dataAvailableNotified` is false or true, the new `flushRequested` should alway be true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 539aab54392550e3fc872cfa70681e6593b1a46e Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160699412) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649)
* d34a27ea803c0203027ec4cc5fb751bb30d51bad Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160839179) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11786: [FLINK-17208][network]
Reduce redundant data available notifications of PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0fd4119b3171f384375c3cd683b850b80c42e77 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410367542
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -146,7 +149,10 @@ private boolean add(BufferConsumer bufferConsumer, boolean finish, boolean inser
handleAddingBarrier(bufferConsumer, insertAsHead);
updateStatistics(bufferConsumer);
increaseBuffersInBacklog(bufferConsumer);
- notifyDataAvailable = insertAsHead || finish || shouldNotifyDataAvailable();
+
+ // Notify only when we added first finished buffer.
+ notifyDataAvailable = mayNotifyDataAvailable() && getNumberOfFinishedBuffers() == 1;
+ dataAvailableNotified = dataAvailableNotified || notifyDataAvailable;
Review comment:
We can remove `dataAvailableNotified = dataAvailableNotified || notifyDataAvailable` and migrate it into internal `#notifyDataAvailable()` to tag `dataAvailableNotified = true` instead. There are two benefits:
1. It is more easily understood after actually calling `#notifyDataAvailable`, then set it as true.
2. It can be reused for three below places, which i will point it out below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160850008",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66188949ff1646c298d32df7fe45c6745f771bc1 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160850008) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410362251
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -146,7 +149,10 @@ private boolean add(BufferConsumer bufferConsumer, boolean finish, boolean inser
handleAddingBarrier(bufferConsumer, insertAsHead);
updateStatistics(bufferConsumer);
increaseBuffersInBacklog(bufferConsumer);
- notifyDataAvailable = insertAsHead || finish || shouldNotifyDataAvailable();
+
+ // Notify only when we added first finished buffer.
+ notifyDataAvailable = mayNotifyDataAvailable() && getNumberOfFinishedBuffers() == 1;
+ dataAvailableNotified = dataAvailableNotified || notifyDataAvailable;
Review comment:
it is not easy to identify `dataAvailableNotified` with `notifyDataAvailable` together. How about renaming `dataAvailableNotified` as `alreadyNotified` and `notifyDataAvailable` as `shouldNotify`, which might seem more clearly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d34a27ea803c0203027ec4cc5fb751bb30d51bad Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160839179) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706)
* 66188949ff1646c298d32df7fe45c6745f771bc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160850008",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7714",
"triggerID" : "66188949ff1646c298d32df7fe45c6745f771bc1",
"triggerType" : "PUSH"
}, {
"hash" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160877666",
"triggerID" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"triggerType" : "PUSH"
}, {
"hash" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7719",
"triggerID" : "ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab6e2e33d46724a5694a66b13bba1d8a6fdbbdc1 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160877666) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7719)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410355533
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -434,15 +445,12 @@ public int getBuffersInBacklog() {
}
}
- private boolean shouldNotifyDataAvailable() {
- // Notify only when we added first finished buffer.
- return readView != null && !flushRequested && getNumberOfFinishedBuffers() == 1;
+ private boolean mayNotifyDataAvailable() {
+ return readView != null && !dataAvailableNotified;
}
private void notifyDataAvailable() {
Review comment:
we can remove this method completely, because calling this method has no difference with calling `readView.notifyDataAvailable()` directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d34a27ea803c0203027ec4cc5fb751bb30d51bad Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160839179) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#issuecomment-615087816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160684486",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7637",
"triggerID" : "c0fd4119b3171f384375c3cd683b850b80c42e77",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160699412",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7649",
"triggerID" : "539aab54392550e3fc872cfa70681e6593b1a46e",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160839179",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
}, {
"hash" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706",
"triggerID" : "d34a27ea803c0203027ec4cc5fb751bb30d51bad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d34a27ea803c0203027ec4cc5fb751bb30d51bad Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160839179) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7706)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services