[GitHub] [inlong] dockerzhang commented on a diff in pull request #6184: [INLONG-6181][Agent][Dataproxy][SDK] Support node protocol reporting and query

[GitBox <gi...@apache.org>]

dockerzhang commented on code in PR #6184:
URL: https://github.com/apache/inlong/pull/6184#discussion_r996652178


##########
inlong-dataproxy/conf/common.properties:
##########
@@ -23,14 +23,16 @@ manager.hosts=127.0.0.1:8083
 manager.auth.secretId=
 manager.auth.secretKey=
 proxy.report.ip=127.0.0.1
-proxy.report.port=46801
+proxy.report.tcp.port=46801
+proxy.report.http.port=46802
+#support HTTP or TCP, default TCP. for example: proxy.report.protocol.type=TCP, proxy.report.protocol.type=HTTP, proxy.report.protocol.type=TCP,HTTP
+proxy.report.protocol.type=TCP

Review Comment:
   ->
   \# support HTTP/TCP/TCP,HTTP
   proxy.report.protocol.type=TCP
   proxy.report.tcp.port=46801
   proxy.report.http.port=46802



##########
inlong-dataproxy/dataproxy-docker/dataproxy-docker.sh:
##########
@@ -21,6 +21,9 @@ local_ip=$(ifconfig | grep inet | grep -v inet6 | grep -v "127.0.0.1" | awk '{pr
 # config
 cd "${file_path}/"
 common_conf_file=./conf/common.properties
+pulsar_conf_file=./conf/dataproxy-pulsar.conf
+tube_conf_file=./conf/dataproxy-tube.conf

Review Comment:
   here we can add CONFIG_FILE="dataproxy-${MQ_TYPE}.conf" to define different configuration file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org