You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ds...@apache.org on 2016/12/21 21:49:55 UTC

geode git commit: when adding to the expiredTombstones ArrayList the code now holds a sync on getBlockGCLock.

Repository: geode
Updated Branches:
  refs/heads/feature/GEODE-2240 [created] aaaad80dc


when adding to the expiredTombstones ArrayList the code
now holds a sync on getBlockGCLock.


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/aaaad80d
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/aaaad80d
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/aaaad80d

Branch: refs/heads/feature/GEODE-2240
Commit: aaaad80dc5636713822c7abf746241251e1cf964
Parents: 2fb15ae
Author: Darrel Schneider <ds...@pivotal.io>
Authored: Wed Dec 21 13:48:32 2016 -0800
Committer: Darrel Schneider <ds...@pivotal.io>
Committed: Wed Dec 21 13:48:32 2016 -0800

----------------------------------------------------------------------
 .../java/org/apache/geode/internal/cache/TombstoneService.java   | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/aaaad80d/geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java b/geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
index 2840134..7032775 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
@@ -669,7 +669,9 @@ public class TombstoneService {
       if (logger.isTraceEnabled(LogMarker.TOMBSTONE)) {
         logger.trace(LogMarker.TOMBSTONE, "adding expired tombstone {} to batch", tombstone);
       }
-      expiredTombstones.add(tombstone);
+      synchronized (getBlockGCLock()) {
+        expiredTombstones.add(tombstone);
+      }
     }
 
     @Override