You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/15 17:05:46 UTC
[GitHub] [dubbo-go] watermelo opened a new pull request #879: feat: move task pool to endpoint layer
watermelo opened a new pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (006e4a5) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/68ff8be79d6d23fc5f170237b2044e312acf8be5?el=desc) (68ff8be) will **decrease** coverage by `0.00%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 59.85% 59.85% -0.01%
===========================================
Files 260 260
Lines 12854 12832 -22
===========================================
- Hits 7694 7680 -14
+ Misses 4199 4190 -9
- Partials 961 962 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `42.50% <0.00%> (+0.52%)` | :arrow_up: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `44.44% <33.33%> (+2.48%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `70.31% <57.14%> (+1.59%)` | :arrow_up: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [68ff8be...006e4a5](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (ba96f44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/68ff8be79d6d23fc5f170237b2044e312acf8be5?el=desc) (68ff8be) will **decrease** coverage by `0.12%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 59.85% 59.73% -0.13%
===========================================
Files 260 260
Lines 12854 12832 -22
===========================================
- Hits 7694 7665 -29
- Misses 4199 4201 +2
- Partials 961 966 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `42.50% <0.00%> (+0.52%)` | :arrow_up: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `44.44% <33.33%> (+2.48%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `65.75% <57.14%> (-2.97%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [68ff8be...ba96f44](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (2cacfc7) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/ce90b4b3a30cb5956e03d9d1031aa1d4066f8b88?el=desc) (ce90b4b) will **decrease** coverage by `0.05%`.
> The diff coverage is `52.17%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 60.19% 60.13% -0.06%
===========================================
Files 260 260
Lines 12884 12860 -24
===========================================
- Hits 7755 7734 -21
+ Misses 4172 4165 -7
- Partials 957 961 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `17.59% <0.00%> (ø)` | |
| [...gistry/event/event\_publishing\_service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXZlbnQvZXZlbnRfcHVibGlzaGluZ19zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.71% <ø> (ø)` | |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.74% <ø> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `42.50% <0.00%> (+0.52%)` | :arrow_up: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `44.32% <33.33%> (+2.36%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `65.89% <57.14%> (-3.71%)` | :arrow_down: |
| [registry/consul/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `73.64% <100.00%> (ø)` | |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <100.00%> (ø)` | |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `81.20% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [ce90b4b...2cacfc7](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (1c1c7d3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e308e19ad2c0c61738cd496d834bb322b0a0e626?el=desc) (e308e19) will **decrease** coverage by `0.05%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 59.91% 59.85% -0.06%
===========================================
Files 261 261
Lines 12912 12884 -28
===========================================
- Hits 7736 7712 -24
+ Misses 4224 4218 -6
- Partials 952 954 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `17.59% <0.00%> (ø)` | |
| [...gistry/event/event\_publishing\_service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXZlbnQvZXZlbnRfcHVibGlzaGluZ19zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.71% <ø> (ø)` | |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.74% <ø> (ø)` | |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `45.83% <60.00%> (+3.86%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `66.82% <85.71%> (-1.91%)` | :arrow_down: |
| [registry/consul/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `73.33% <100.00%> (ø)` | |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <100.00%> (ø)` | |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `81.20% <100.00%> (ø)` | |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `44.30% <100.00%> (+2.32%)` | :arrow_up: |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [e308e19...1c1c7d3](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-744034656
pls update dubbo-getty to v1.4.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (2cacfc7) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/ce90b4b3a30cb5956e03d9d1031aa1d4066f8b88?el=desc) (ce90b4b) will **decrease** coverage by `0.05%`.
> The diff coverage is `52.17%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 60.19% 60.13% -0.06%
===========================================
Files 260 260
Lines 12884 12860 -24
===========================================
- Hits 7755 7734 -21
+ Misses 4172 4165 -7
- Partials 957 961 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `17.59% <0.00%> (ø)` | |
| [...gistry/event/event\_publishing\_service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXZlbnQvZXZlbnRfcHVibGlzaGluZ19zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.71% <ø> (ø)` | |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.74% <ø> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `42.50% <0.00%> (+0.52%)` | :arrow_up: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `44.32% <33.33%> (+2.36%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `65.89% <57.14%> (-3.71%)` | :arrow_down: |
| [registry/consul/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `73.64% <100.00%> (ø)` | |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <100.00%> (ø)` | |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `81.20% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [ce90b4b...d6bf494](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (ba96f44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/ce90b4b3a30cb5956e03d9d1031aa1d4066f8b88?el=desc) (ce90b4b) will **decrease** coverage by `0.45%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 60.19% 59.73% -0.46%
===========================================
Files 260 260
Lines 12884 12832 -52
===========================================
- Hits 7755 7665 -90
- Misses 4172 4201 +29
- Partials 957 966 +9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `42.50% <0.00%> (+0.52%)` | :arrow_up: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `44.44% <33.33%> (+2.48%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `65.75% <57.14%> (-3.86%)` | :arrow_down: |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `44.44% <0.00%> (-12.70%)` | :arrow_down: |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `28.57% <0.00%> (-11.43%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-10.82%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `74.01% <0.00%> (-5.72%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [ce90b4b...2cacfc7](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#discussion_r548792957
##########
File path: remoting/getty/getty_server.go
##########
@@ -210,17 +192,17 @@ func (s *Server) Start() {
)
addr = s.addr
+ serverOpts := []getty.ServerOption{getty.WithLocalAddress(addr)}
if s.conf.SSLEnabled {
- tcpServer = getty.NewTCPServer(
- getty.WithLocalAddress(addr),
- getty.WithServerSslEnabled(s.conf.SSLEnabled),
- getty.WithServerTlsConfigBuilder(config.GetServerTlsConfigBuilder()),
- )
- } else {
- tcpServer = getty.NewTCPServer(
- getty.WithLocalAddress(addr),
- )
+ serverOpts = append(serverOpts, getty.WithServerSslEnabled(s.conf.SSLEnabled),
+ getty.WithServerTlsConfigBuilder(config.GetServerTlsConfigBuilder()))
}
+
+ if s.conf.GrPoolSize != 0 {
Review comment:
!= 0 ？what about < 0? Is that a right logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (006e4a5) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/68ff8be79d6d23fc5f170237b2044e312acf8be5?el=desc) (68ff8be) will **increase** coverage by `0.04%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
+ Coverage 59.85% 59.90% +0.04%
===========================================
Files 260 260
Lines 12854 12832 -22
===========================================
- Hits 7694 7687 -7
+ Misses 4199 4185 -14
+ Partials 961 960 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `42.50% <0.00%> (+0.52%)` | :arrow_up: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `44.44% <33.33%> (+2.48%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `71.23% <57.14%> (+2.51%)` | :arrow_up: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `53.68% <0.00%> (+3.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [68ff8be...006e4a5](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] watermelo edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
watermelo edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-727602821
Related PR:
https://github.com/dubbogo/gost/pull/35
https://github.com/apache/dubbo-getty/pull/50
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (ba96f44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/ce90b4b3a30cb5956e03d9d1031aa1d4066f8b88?el=desc) (ce90b4b) will **decrease** coverage by `0.45%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 60.19% 59.73% -0.46%
===========================================
Files 260 260
Lines 12884 12832 -52
===========================================
- Hits 7755 7665 -90
- Misses 4172 4201 +29
- Partials 957 966 +9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `42.50% <0.00%> (+0.52%)` | :arrow_up: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `44.44% <33.33%> (+2.48%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `65.75% <57.14%> (-3.86%)` | :arrow_down: |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `44.44% <0.00%> (-12.70%)` | :arrow_down: |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `28.57% <0.00%> (-11.43%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-10.82%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `74.01% <0.00%> (-5.72%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [ce90b4b...1cc462b](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (d6bf494) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/ce90b4b3a30cb5956e03d9d1031aa1d4066f8b88?el=desc) (ce90b4b) will **decrease** coverage by `0.26%`.
> The diff coverage is `72.72%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 60.19% 59.92% -0.27%
===========================================
Files 260 261 +1
Lines 12884 12886 +2
===========================================
- Hits 7755 7722 -33
- Misses 4172 4212 +40
+ Partials 957 952 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `17.59% <0.00%> (ø)` | |
| [...gistry/event/event\_publishing\_service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXZlbnQvZXZlbnRfcHVibGlzaGluZ19zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.71% <ø> (ø)` | |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.74% <ø> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `48.17% <0.00%> (-2.19%)` | :arrow_down: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `45.83% <60.00%> (+3.86%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `66.82% <85.71%> (-2.79%)` | :arrow_down: |
| [registry/consul/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `73.33% <100.00%> (-0.32%)` | :arrow_down: |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <100.00%> (ø)` | |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `81.20% <100.00%> (ø)` | |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `44.30% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [ce90b4b...d6bf494](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-739142641
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=h1) Report
> Merging [#879](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=desc) (1c1c7d3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e308e19ad2c0c61738cd496d834bb322b0a0e626?el=desc) (e308e19) will **decrease** coverage by `0.05%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #879 +/- ##
===========================================
- Coverage 59.91% 59.85% -0.06%
===========================================
Files 261 261
Lines 12912 12884 -28
===========================================
- Hits 7736 7712 -24
+ Misses 4224 4218 -6
- Partials 952 954 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `17.59% <0.00%> (ø)` | |
| [...gistry/event/event\_publishing\_service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXZlbnQvZXZlbnRfcHVibGlzaGluZ19zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.71% <ø> (ø)` | |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `45.74% <ø> (ø)` | |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `45.83% <60.00%> (+3.86%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `66.82% <85.71%> (-1.91%)` | :arrow_down: |
| [registry/consul/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `73.33% <100.00%> (ø)` | |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <100.00%> (ø)` | |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `81.20% <100.00%> (ø)` | |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `44.30% <100.00%> (+2.32%)` | :arrow_up: |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/879/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=footer). Last update [e308e19...8d0ccff](https://codecov.io/gh/apache/dubbo-go/pull/879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] watermelo commented on pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
watermelo commented on pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#issuecomment-727602821
Related PR https://github.com/dubbogo/gost/pull/35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#discussion_r548793157
##########
File path: remoting/getty/getty_client.go
##########
@@ -102,8 +102,7 @@ func SetClientConf(c ClientConfig) {
func setClientGrpool() {
if clientConf.GrPoolSize > 1 {
- clientGrpool = gxsync.NewTaskPool(gxsync.WithTaskPoolTaskPoolSize(clientConf.GrPoolSize), gxsync.WithTaskPoolTaskQueueLength(clientConf.QueueLen),
- gxsync.WithTaskPoolTaskQueueNumber(clientConf.QueueNumber))
+ clientGrpool = gxsync.NewTaskPoolSimple(clientConf.GrPoolSize)
Review comment:
@watermelo reply this comment pls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #879: Ftr: move task pool to endpoint layer
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #879:
URL: https://github.com/apache/dubbo-go/pull/879#discussion_r533069371
##########
File path: remoting/getty/getty_client.go
##########
@@ -102,8 +102,7 @@ func SetClientConf(c ClientConfig) {
func setClientGrpool() {
if clientConf.GrPoolSize > 1 {
- clientGrpool = gxsync.NewTaskPool(gxsync.WithTaskPoolTaskPoolSize(clientConf.GrPoolSize), gxsync.WithTaskPoolTaskQueueLength(clientConf.QueueLen),
- gxsync.WithTaskPoolTaskQueueNumber(clientConf.QueueNumber))
+ clientGrpool = gxsync.NewTaskPoolSimple(clientConf.GrPoolSize)
Review comment:
pls validate clientConf.GrPoolSize and set a default value if it's illegal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org