You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/09/28 11:43:02 UTC
[GitHub] [datasketches-java] davecromberge opened a new pull request #367: Remove deprecated methods
davecromberge opened a new pull request #367:
URL: https://github.com/apache/datasketches-java/pull/367
Release v3.0.0 preparation
Since this is a major release, methods marked with a deprecation notice are now removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] davecromberge commented on pull request #367: Remove deprecated methods
Posted by GitBox <gi...@apache.org>.
davecromberge commented on pull request #367:
URL: https://github.com/apache/datasketches-java/pull/367#issuecomment-929176235
Unfortunately this task is not complete. I was unable to definitively remove PairwiseSetOperations because there was some corner case testing that looks important. Also, there are some tests that have "Deprecated" in the case name but I cannot determine why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] davecromberge commented on pull request #367: Remove deprecated methods
Posted by GitBox <gi...@apache.org>.
davecromberge commented on pull request #367:
URL: https://github.com/apache/datasketches-java/pull/367#issuecomment-929176235
Unfortunately this task is not complete. I was unable to definitively remove PairwiseSetOperations because there was some corner case testing that looks important. Also, there are some tests that have "Deprecated" in the case name but I cannot determine why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] davecromberge edited a comment on pull request #367: Remove deprecated methods
Posted by GitBox <gi...@apache.org>.
davecromberge edited a comment on pull request #367:
URL: https://github.com/apache/datasketches-java/pull/367#issuecomment-929176235
Unfortunately this task is not complete. I was unable to definitively remove PairwiseSetOperations because there was some corner case testing that looks important. Also, there are some tests that have "Deprecated" in the case name but I cannot determine why.
```
datasketches-java:remove-deprecated-methods find . -name "*.java" -type f -print | xargs grep -i -n -s -A0 "deprecated"
./src/test/java/org/apache/datasketches/quantiles/DoublesUnionBuilderTest.java:59:public void checkDeprecated1() {
./src/test/java/org/apache/datasketches/quantiles/HeapUpdateDoublesSketchTest.java:817: public void checkKisTwoDeprecated() {
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:32: * @deprecated v2.0.0. This class has been deprecated as equivalent functionality has been added to the
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:35:@Deprecated
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:46: * @deprecated v2.0.0. Use {@link Intersection#intersect(Sketch, Sketch)} instead, which has more
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:49: @Deprecated
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:63: * @deprecated v2.0.0. Use {@link AnotB#aNotB(Sketch, Sketch)} instead, which has more
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:66: @Deprecated
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:83: * @deprecated v2.0.0. Please use {@link Union#union(Sketch, Sketch)} instead, which has more
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:86: @Deprecated
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:104: * @deprecated v2.0.0. Please use {@link Union#union(Sketch, Sketch)} instead, which has more
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:107: @Deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho merged pull request #367: Remove deprecated methods
Posted by GitBox <gi...@apache.org>.
leerho merged pull request #367:
URL: https://github.com/apache/datasketches-java/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] davecromberge edited a comment on pull request #367: Remove deprecated methods
Posted by GitBox <gi...@apache.org>.
davecromberge edited a comment on pull request #367:
URL: https://github.com/apache/datasketches-java/pull/367#issuecomment-929176235
Unfortunately this task is not complete. I was unable to definitively remove PairwiseSetOperations because there was some corner case testing that looks important. Also, there are some tests that have "Deprecated" in the case name but I cannot determine why.
```
datasketches-java:remove-deprecated-methods find . -name "*.java" -type f -print | xargs grep -i -n -s -A0 "deprecated"
./src/test/java/org/apache/datasketches/quantiles/DoublesUnionBuilderTest.java:59:public void checkDeprecated1() {
./src/test/java/org/apache/datasketches/quantiles/HeapUpdateDoublesSketchTest.java:817: public void checkKisTwoDeprecated() {
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:32: * @deprecated v2.0.0. This class has been deprecated as equivalent functionality has been added to the
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:35:@Deprecated
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:46: * @deprecated v2.0.0. Use {@link Intersection#intersect(Sketch, Sketch)} instead, which has more
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:49: @Deprecated
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:63: * @deprecated v2.0.0. Use {@link AnotB#aNotB(Sketch, Sketch)} instead, which has more
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:66: @Deprecated
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:83: * @deprecated v2.0.0. Please use {@link Union#union(Sketch, Sketch)} instead, which has more
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:86: @Deprecated
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:104: * @deprecated v2.0.0. Please use {@link Union#union(Sketch, Sketch)} instead, which has more
./src/main/java/org/apache/datasketches/theta/PairwiseSetOperations.java:107: @Deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org