You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/11/04 18:03:27 UTC
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22019
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
KUDU-3623 do not crash on invalid input for 'kudu table copy'
This patch adds code to handle invalid input for the --predicates flag
of the 'kudu table copy' tool. Now, instead of crashing on any
non-expected input, the tool exists gracefully and reports an actionable
error message. With that, now it's easier to understand what was wrong,
correct typos/mistakes, and re-run the tool again, eventually achieving
the desired goal.
A new test is added to cover the newly introduced functionality.
This is a follow-up to 0afeddf9e530762e0e47beb7428982763715c746.
Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Reviewed-on: http://gerrit.cloudera.org:8080/22009
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit 89ebb94e4a1b79557b3d3e8482edcd0352bf6968)
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
2 files changed, 281 insertions(+), 88 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/22019/1
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22019 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/660/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Nov 2024 02:36:56 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22019 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/660/
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Nov 2024 00:40:11 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22019 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Nov 2024 18:06:20 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22019 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
KUDU-3623 do not crash on invalid input for 'kudu table copy'
This patch adds code to handle invalid input for the --predicates flag
of the 'kudu table copy' tool. Now, instead of crashing on any
non-expected input, the tool exists gracefully and reports an actionable
error message. With that, now it's easier to understand what was wrong,
correct typos/mistakes, and re-run the tool again, eventually achieving
the desired goal.
A new test is added to cover the newly introduced functionality.
This is a follow-up to 0afeddf9e530762e0e47beb7428982763715c746.
Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Reviewed-on: http://gerrit.cloudera.org:8080/22009
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit 89ebb94e4a1b79557b3d3e8482edcd0352bf6968)
Reviewed-on: http://gerrit.cloudera.org:8080/22019
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
2 files changed, 281 insertions(+), 88 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22019 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
Patch Set 2: Verified+1
unrelated test failures:
* RELEASE: master_replication-itest
* TSAN: unrelated Java tests
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Nov 2024 03:27:36 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22019 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/654/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Nov 2024 19:39:17 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22019 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
Patch Set 2: Code-Review+2
carrying over Abhishek's +2 from PS1
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Nov 2024 03:28:30 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.17.x) KUDU-3623 do not crash on invalid input for 'kudu table copy'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22019 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy'
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/654/
--
To view, visit http://gerrit.cloudera.org:8080/22019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Nov 2024 18:03:40 +0000
Gerrit-HasComments: No