[jira] [Comment Edited] (IGNITE-11155) Add JVM options analysis to Ignition.start() or handle and comment exceptions

["Dmitriy Pavlov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-11155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764938#comment-16764938 ] 

Dmitriy Pavlov edited comment on IGNITE-11155 at 2/11/19 1:10 PM:
------------------------------------------------------------------

[~ibessonov] thank you for review.

[~dmagda] thank you for your valuable proposal. I'll add demarcation of parameters in the warning.

I suggest keeping the link in the warning because
 - It shows users, that product is trying to help them to solve the issue, it is a positive thing, even if the section will be renamed. At least page should be available. 
 - It is easy to find in IntelliJ Idea/Teamcity logs because the link is {color:#59afe1}+blue+{color} (near error text, which is {color:#d04437}red{color}). It underlines that it is not just NPE or OOME, but the problem which has a solution and advice about it. It may help the user to continue to try Ignite examples instead of a too fast decision that product is not operational.


was (Author: dpavlov):
[~ibessonov] thank you for review.

[~dmagda] thank you for your valuable proposal. I'll add demarcation of parameters in the warning.

I suggest keeping the link in the warning because
 - It shows users, that product is trying to help them to solve the issue, it is a positive thing, even if the section will be renamed. At least page should be available. 
 - It is easy to find in IntelliJ Idea/Teamcity logs because the link is {color:#59afe1}+blue +{color}(which err. text, which is {color:#d04437}red{color}). It underlines that it is not just NPE or OOME, but the problem which has a solution and advice about it. It may help the user to continue to try Ignite examples instead of a too fast decision that product is not operational.

> Add JVM options analysis to Ignition.start() or handle and comment exceptions
> -----------------------------------------------------------------------------
>
>                 Key: IGNITE-11155
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11155
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Dmitriy Pavlov
>            Assignee: Dmitriy Pavlov
>            Priority: Major
>             Fix For: 2.8
>
>         Attachments: start-java11.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In Ignite examples or using Ignite Embedded mode (using direct Ignition.start() call from a user IDE), may fail with exceptions for JDKs newer than 8.
> It may confuse the user. Instead of just logging an exception it is better to output message with advice on how to fix it. E.g.
> {noformat}
> Please make sure --add-exports=java.base/sun.nio.ch=ALL-UNNAMED is enabled. 
> See https://apacheignite.readme.io/docs/getting-started#section-running-ignite-with-java-9-10-11 for more info
> {noformat}
> Modern IDEs like IntelliJ will display the link as a clickable hyperlink and Ignite in embedded mode will show how to set up Application configuration 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)