You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/15 12:20:14 UTC
[GitHub] [airflow] potiuk opened a new pull request #17023: Fixes "development" and "rc" cross dependencies between providers
potiuk opened a new pull request #17023:
URL: https://github.com/apache/airflow/pull/17023
In case we have additional dependencies between providers released
at the same time (for example we need to release sftp and ssh
packages now where sftp package depends on release of ssh
at the same time) we have to add suffix to the version of the
additional_dependency.
PIP does not take into account unfortunately that development
dependencies should likely be considered as fulfilling the
requirement of >=. For example if you have:
sftp depends on ssh>=2.1.0 and you release ssh 2.1.0.dev0 at
the same time the ssh>=2.1.0 condition is not fulfilled.
Same case will be with rc1. Therefore we need to add the suffix in such
cross-provider dependencies to be able to install them in CI
and in rc candidates.
In the future we might ask PIP to change behaviour in such case.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17023: Fixes "development" and "rc" cross dependencies between providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17023:
URL: https://github.com/apache/airflow/pull/17023#issuecomment-880649812
Hey @uranusjr -> can you please take a look at that one? I think there is an improvement to PIP handling dev dependencies (but there might be good reasons why it is done like that currently). I workarounded the problem for now, but maybe we can improve it in PIP ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17023: Fixes "development" and "rc" cross dependencies between providers
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17023:
URL: https://github.com/apache/airflow/pull/17023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17023: Fixes "development" and "rc" cross dependencies between providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17023:
URL: https://github.com/apache/airflow/pull/17023#issuecomment-880690918
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org