You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Israel Ekpo <is...@aicer.org> on 2013/04/01 20:24:55 UTC

Review Request: Corrections to Developer and User Guides for 1.4

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10222/
-----------------------------------------------------------

Review request for Flume, Mike Percy and Hari Shreedharan.


Description
-------

Changes to the following files:
flume-ng-doc/sphinx/FlumeDeveloperGuide.rst (clarification that a sink can only read from one channel)
flume-ng-doc/sphinx/FlumeUserGuide.rst (grammatical, punctuation and spelling changes)
flume-ng-doc/sphinx/index.rst (updated to reflect the switch to GIT from SVN)


This addresses bug FLUME-1953.
    https://issues.apache.org/jira/browse/FLUME-1953


Diffs
-----

  flume-ng-doc/sphinx/FlumeDeveloperGuide.rst 02b0088 
  flume-ng-doc/sphinx/FlumeUserGuide.rst 600a360 
  flume-ng-doc/sphinx/index.rst 1903790 

Diff: https://reviews.apache.org/r/10222/diff/


Testing
-------

Not applicable


Thanks,

Israel Ekpo

Re: Review Request 10222: Corrections to Developer and User Guides for 1.4

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10222/#review23345
-----------------------------------------------------------

Ship it!


Hm, was missed to commit?

- Alexander Alten-Lorenz


On April 1, 2013, 6:34 p.m., Israel Ekpo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10222/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 6:34 p.m.)
> 
> 
> Review request for Flume, Hari Shreedharan, Juhani Connolly, and Mike Percy.
> 
> 
> Bugs: FLUME-1953
>     https://issues.apache.org/jira/browse/FLUME-1953
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Changes to the following files:
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst (clarification that a sink can only read from one channel)
> flume-ng-doc/sphinx/FlumeUserGuide.rst (grammatical, punctuation and spelling changes)
> flume-ng-doc/sphinx/index.rst (updated to reflect the switch to GIT from SVN)
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeDeveloperGuide.rst 02b0088 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 600a360 
>   flume-ng-doc/sphinx/index.rst 1903790 
> 
> Diff: https://reviews.apache.org/r/10222/diff/
> 
> 
> Testing
> -------
> 
> Not applicable
> 
> 
> File Attachments
> ----------------
> 
> FLUME-1953
>   https://reviews.apache.org/media/uploaded/files/2013/04/01/FLUME-1953.patch
> 
> 
> Thanks,
> 
> Israel Ekpo
> 
>

Re: Review Request: Corrections to Developer and User Guides for 1.4

Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10222/#review18674
-----------------------------------------------------------

Ship it!


+1, looks good, fixing a minor RST rendering issue on commit

- Mike Percy


On April 1, 2013, 6:34 p.m., Israel Ekpo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10222/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 6:34 p.m.)
> 
> 
> Review request for Flume, Juhani Connolly, Mike Percy, and Hari Shreedharan.
> 
> 
> Description
> -------
> 
> Changes to the following files:
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst (clarification that a sink can only read from one channel)
> flume-ng-doc/sphinx/FlumeUserGuide.rst (grammatical, punctuation and spelling changes)
> flume-ng-doc/sphinx/index.rst (updated to reflect the switch to GIT from SVN)
> 
> 
> This addresses bug FLUME-1953.
>     https://issues.apache.org/jira/browse/FLUME-1953
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeDeveloperGuide.rst 02b0088 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 600a360 
>   flume-ng-doc/sphinx/index.rst 1903790 
> 
> Diff: https://reviews.apache.org/r/10222/diff/
> 
> 
> Testing
> -------
> 
> Not applicable
> 
> 
> Thanks,
> 
> Israel Ekpo
> 
>

Re: Review Request: Corrections to Developer and User Guides for 1.4

Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10222/
-----------------------------------------------------------

(Updated April 1, 2013, 6:34 p.m.)


Review request for Flume, Juhani Connolly, Mike Percy, and Hari Shreedharan.


Description
-------

Changes to the following files:
flume-ng-doc/sphinx/FlumeDeveloperGuide.rst (clarification that a sink can only read from one channel)
flume-ng-doc/sphinx/FlumeUserGuide.rst (grammatical, punctuation and spelling changes)
flume-ng-doc/sphinx/index.rst (updated to reflect the switch to GIT from SVN)


This addresses bug FLUME-1953.
    https://issues.apache.org/jira/browse/FLUME-1953


Diffs
-----

  flume-ng-doc/sphinx/FlumeDeveloperGuide.rst 02b0088 
  flume-ng-doc/sphinx/FlumeUserGuide.rst 600a360 
  flume-ng-doc/sphinx/index.rst 1903790 

Diff: https://reviews.apache.org/r/10222/diff/


Testing
-------

Not applicable


Thanks,

Israel Ekpo

Re: Review Request: Corrections to Developer and User Guides for 1.4

Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10222/
-----------------------------------------------------------

(Updated April 1, 2013, 6:26 p.m.)


Review request for Flume, Mike Percy and Hari Shreedharan.


Changes
-------

Here is a summary of what the patch contains:
correction to flume-ng-doc/sphinx/FlumeDeveloperGuide.rst to clarify that a sink can only read from one channel.
grammatical, punctuation and spelling changes to flume-ng-doc/sphinx/FlumeUserGuide.rst
correction to flume-ng-doc/sphinx/index.rst to show that we are now using GIT instead of SVN.


Description
-------

Changes to the following files:
flume-ng-doc/sphinx/FlumeDeveloperGuide.rst (clarification that a sink can only read from one channel)
flume-ng-doc/sphinx/FlumeUserGuide.rst (grammatical, punctuation and spelling changes)
flume-ng-doc/sphinx/index.rst (updated to reflect the switch to GIT from SVN)


This addresses bug FLUME-1953.
    https://issues.apache.org/jira/browse/FLUME-1953


Diffs
-----

  flume-ng-doc/sphinx/FlumeDeveloperGuide.rst 02b0088 
  flume-ng-doc/sphinx/FlumeUserGuide.rst 600a360 
  flume-ng-doc/sphinx/index.rst 1903790 

Diff: https://reviews.apache.org/r/10222/diff/


Testing
-------

Not applicable


Thanks,

Israel Ekpo