You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/24 20:31:43 UTC
[GitHub] [netbeans] ebarboni opened a new pull request #3851: add-open flag for archetype
ebarboni opened a new pull request #3851:
URL: https://github.com/apache/netbeans/pull/3851
Attempt to pass the add open flags to archetype linked to use for https://github.com/apache/netbeans-mavenutils-archetype-nbm-archetype/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #3851: add-open flag for archetype
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3851:
URL: https://github.com/apache/netbeans/pull/3851#issuecomment-1079171899
#3862 needs also the jvm version for flags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #3851: add-open flag for archetype
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3851:
URL: https://github.com/apache/netbeans/pull/3851#issuecomment-1078847299
it add flag like this '''-J--add-opens=java.base/java.net=ALL-UNNAMED -J--add-opens=java.base/java.lang.ref=ALL-UNNAMED''' maybe we should have the without -J version too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a change in pull request #3851: add-open flag for archetype
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #3851:
URL: https://github.com/apache/netbeans/pull/3851#discussion_r835115591
##########
File path: nbbuild/build.xml
##########
@@ -138,6 +138,7 @@
<property file="${nb_all}/nbbuild/build/netbeansrelease.properties"/>
<!-- javadoc content filtering -->
<setjavadoc branch="${metabuild.branch}"/>
+ <antcall target="-load-module-flags"/>
Review comment:
it works but the -load module append the file I guess that replacement reread the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3851: add-open flag for archetype
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3851:
URL: https://github.com/apache/netbeans/pull/3851#discussion_r834901491
##########
File path: nbbuild/build.xml
##########
@@ -138,6 +138,7 @@
<property file="${nb_all}/nbbuild/build/netbeansrelease.properties"/>
<!-- javadoc content filtering -->
<setjavadoc branch="${metabuild.branch}"/>
+ <antcall target="-load-module-flags"/>
Review comment:
does this work? I thought antcall would run in its own context and the property would be empty after it. (I am a bit rusty with ant)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #3851: add-open flag for archetype
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3851:
URL: https://github.com/apache/netbeans/pull/3851#issuecomment-1078968901
@mbien add the two properties for maven user will be easy to get both I guess even if user doesn't want them at the end. Easier to delete than to create.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #3851: add-open flag for archetype
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3851:
URL: https://github.com/apache/netbeans/pull/3851#issuecomment-1079226250
wait PR to be merged and git checkout build.xml and default.xml. Idea of @matthiasblaesing was my first intention but did'nt proper understand where to put things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists