[GitHub] [phoenix] gokceni commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes

[GitBox <gi...@apache.org>]

gokceni commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535776156



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##########
@@ -326,10 +326,10 @@ private void repairIndexRows(byte[] indexRowKey, long ts, List<Cell> row) throws
                 buildIndexScan.setAttribute(BaseScannerRegionObserver.REBUILD_INDEXES, TRUE_BYTES);
                 buildIndexScan.setAttribute(BaseScannerRegionObserver.SKIP_REGION_BOUNDARY_CHECK, Bytes.toBytes(true));
                 // Scan only columns included in the index table plus the empty column

Review comment:
       Yes, it is. The difference is that in getAllColumns, you get index cols. The getAllColumnsForDataTable, you get the mapping columns in data table. For example: in index there is Col1 but in hbase it is in a cell with others with column qualifier:1. But in data table it is in its own cell with col qualifier Col1. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org