You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by baank <gi...@git.apache.org> on 2017/08/08 05:08:27 UTC
[GitHub] nifi pull request #2066: NIFI-4256 - Add support for all AWS S3 Encryption O...
GitHub user baank opened a pull request:
https://github.com/apache/nifi/pull/2066
NIFI-4256 - Add support for all AWS S3 Encryption Options
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/baank/nifi NIFI-4256
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2066.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2066
----
commit 1f8df2da50846317513a5b1890f7568368b9eb14
Author: Naden Franciscus <na...@nbnco.com.au>
Date: 2017-08-08T04:55:40Z
NIFI-4256 - Add support for all AWS S3 Encryption Options
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2066: NIFI-4256 - Add support for all AWS S3 Encryption Options
Posted by baank <gi...@git.apache.org>.
Github user baank commented on the issue:
https://github.com/apache/nifi/pull/2066
Sure not a problem. I have already implemented his changes but just need to get a new PR approved and also there was a comment in JIRA regarding whether to include the client side S3 work at all.
---
[GitHub] nifi issue #2066: NIFI-4256 - Add support for all AWS S3 Encryption Options
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2066
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2066: NIFI-4256 - Add support for all AWS S3 Encryption Options
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2066
@baank will you be in a position to help work with @jvwing on review/contrib cycles?
---
[GitHub] nifi issue #2066: NIFI-4256 - Add support for all AWS S3 Encryption Options
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2066
@baank Thanks for putting together this PR, it looks like you put a lot of thought into covering all the possible encryption scenarios. I haven't run it yet, but I have a few starter questions after looking over some of the code:
1. What was the driver behind updating the AWS SDK version?
1. Although the service interfaces and their methods are named specific to encryption, the substance of their interaction are not necessarily limited to encryption. What would you think about making the interfaces more generic? For example:
* Could the S3ClientSideEncryptionService be "S3ClientService" with only `getClient` methods, with the `needsEncryptedClient()` logic being performed internally by the concrete implementation StandardS3ClientSideEncryptionService. I can see a number of use cases beyond encryption that could be covered by a custom client factory.
* Could the S3ServerSideEncryptionService be a more generic S3 put request modifier? My efforts at thinking up a good name failed miserably here. But the interface allows many non-encryption modifications of an S3 request, which might indeed be useful, despite the `encrypt()` naming of the methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---