You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (Updated) (JIRA)" <ji...@apache.org> on 2012/03/22 01:51:26 UTC
[jira] [Updated] (SOLR-3074)
SolrPluginUtils.docListToSolrDocumentList is broken, existing test is also
broken
[ https://issues.apache.org/jira/browse/SOLR-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-3074:
---------------------------
Attachment: SOLR-3074.patch
Oy...
so i started down the road of removing all this from trunk, and then realized i somehow overlooked the fact that clustering is using docListToSolrDocumentList
so then i started trying to fix clustering to have the logic it needed, and then realized that the code i wound up with actually implemented the documented contract of docListToSolrDocumentList in a way that made the new tests in this issue pass.
So this new patch:
* fixes docListToSolrDocumentList
* fixes the test for docListToSolrDocumentList
* removes DocumentBuilder.loadStoredFields
my _new_ plan is to commit as is to trunk, and backport all but the DocumentBuilder.java changes to 3x (i'll just deprecate loadStoredFields in 3x)
comments?
> SolrPluginUtils.docListToSolrDocumentList is broken, existing test is also broken
> ---------------------------------------------------------------------------------
>
> Key: SOLR-3074
> URL: https://issues.apache.org/jira/browse/SOLR-3074
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5
> Reporter: Ahmet Arslan
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3074.patch, SOLR-3074.patch, SOLR-3074.patch
>
>
> testDocListConversion() is not testing what it's suppossed to test. Because added test documents are not committed.
> http://search-lucene.com/m/uwh9l2SHH4e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org