You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Justin Mclean (Jira)" <ji...@apache.org> on 2021/06/11 00:46:00 UTC
[jira] [Comment Edited] (WICKET-6894) Releases doesn't comply with
ASF policy
[ https://issues.apache.org/jira/browse/WICKET-6894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361308#comment-17361308 ]
Justin Mclean edited comment on WICKET-6894 at 6/11/21, 12:45 AM:
------------------------------------------------------------------
Without knowing some of the history here it's a little difficult, but here is some information that would help.
In LICENSE I would expect to see the following licenses:
BSD licensed:
./wicket-examples/src/main/java/org/apache/wicket/examples/preview/dojo.js
MIT license?
./wicket-core/src/test/js/qunit/blanket.min.js
Looks like this includes other 3rd party software from the list of copyright at the top, so their licenses would need to be checked and included.
Red Hat Inc, Apache licensed:
./testing/wicket-arquillian/src/main/resources/META-INF/persistence.xml (and other files)
W3C, W3C document license:
./wicket-util/src/main/java/org/apache/wicket/util/markup/xhtml/xhtml1-strict.dtd
./wicket-util/src/main/java/org/apache/wicket/util/markup/xhtml/xhtml1-transitional.dtd
See https://www.w3.org/Consortium/Legal/copyright-documents-19990405 for the license text.
BSD licensed:
./wicket-examples/src/main/java/org/apache/wicket/examples/preview/behaviour.js
The Apache Software License, Version 1.1
files under ./wicket-util/src/main/java/org/apache/wicket/util/diff
Dual licensed under the MIT or GPL licenses.
./wicket-core/src/test/js/qunit/jquery.mockjax.js
MIT license
./wicket-core/src/test/js/qunit/qunit.js
./wicket-examples/src/main/webapp/js-test/lib/qunit.css
./wicket-examples/src/main/webapp/js-test/lib/qunit.js
MIT licensed
./wicket-examples/src/main/webapp/jquery-ui-1.10.3.custom.js
Apache 2.0 license
files under ./testing/wicket-arquillian/src/main/java/org/apache/wicket/arquillian/
Something funny happen here - double headers
MIT
./wicket-core/src/main/java/org/apache/wicket/resource/jquery/jquery-3.6.0.js
Also includes Sizzle.js (also MIT) s that should be mentioned in LICENSE as well.
MIT or new BSD license.
./wicket-core/src/test/js/amd/require.js
Public domain?
./wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.js
There is also 3 fonts:
./wicket-examples/src/main/resources/org/apache/wicket/examples/fonts/league-gothic/SIL OFL Font License League Gothic.txt
./wicket-examples/src/main/resources/org/apache/wicket/examples/fonts/source-code-pro/SIL OFL Font License Source Code Pro.txt
./wicket-examples/src/main/resources/org/apache/wicket/examples/fonts/source-sans-pro/SIL OFL Font License - Source Sans Pro.txt
These are problematic as their license is Category B and they cannot be included in a source release.
Finally there a number of files missing license headers so I don't know how they are licensed:
./archetypes/quickstart/src/main/resources/archetype-resources/src/main/java/HomePage.java
./archetypes/quickstart/src/main/resources/archetype-resources/src/main/java/WicketApplication.java
./archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java
./archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/TestHomePage.java
./testing/wicket-common-tests/src/test/java/org/apache/wicket/osgi/OsgiClashingPackagesTest.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationConfiguration.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationContext.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/ConstraintIterator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/DefaultPropertyResolver.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/DefaultValidatorProvider.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/DefaultViolationTranslator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/GroupsModel.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/IPropertyResolver.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/ITagModifier.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/IViolationTranslator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/Property.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/PropertyValidator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SessionLocaleInterpolator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SizeTagModifier.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/ValidationModelResolver.java
./wicket-bean-validation/src/test/java/org/apache/wicket/bean/validation/PropertyValidatorRequiredTest.java
./wicket-bean-validation/src/test/java/org/apache/wicket/bean/validation/TestValidatableBean.java
./wicket-bean-validation/src/test/java/org/apache/wicket/bean/validation/ValidationModelResolverTest.java
./wicket-experimental/wicket-metrics/src/main/java/org/apache/wicket/metrics/aspects/WicketFilterInitAspect.java
For the NOTICE file I can't see any reason for any of the the extra text. For example it states " This product includes software from QOS.ch (http://slf4j.org) licensed under the X11 license Copyright (c) 2004-2008 QOS.ch". when a) this is information that should be in LICENSE and bb) QOS.ch is not actually included as far as I can see in the source release. Items that mention BSD and MIT should also be in LICENSE and not NOTICE.
was (Author: jmclean):
Without knowing some of the history here it's a little difficult, but here is some information that would help.
In LICENSE I would expect to see the following licenses:
BSD licensed:
./wicket-examples/src/main/java/org/apache/wicket/examples/preview/dojo.js
MIT license?
./wicket-core/src/test/js/qunit/blanket.min.js
Looks like this includes other 3rd party software from the list of copyright at the top, so their licenses would need to be checked and included.
Red Hat Inc, Apache licensed:
./testing/wicket-arquillian/src/main/resources/META-INF/persistence.xml (and there files)
W3C, W3C document license:
./wicket-util/src/main/java/org/apache/wicket/util/markup/xhtml/xhtml1-strict.dtd
./wicket-util/src/main/java/org/apache/wicket/util/markup/xhtml/xhtml1-transitional.dtd
See https://www.w3.org/Consortium/Legal/copyright-documents-19990405 for the license text.
BSD licensed:
./wicket-examples/src/main/java/org/apache/wicket/examples/preview/behaviour.js
The Apache Software License, Version 1.1
files under ./wicket-util/src/main/java/org/apache/wicket/util/diff
Dual licensed under the MIT or GPL licenses.
./wicket-core/src/test/js/qunit/jquery.mockjax.js
MIT license
./wicket-core/src/test/js/qunit/qunit.js
./wicket-examples/src/main/webapp/js-test/lib/qunit.css
./wicket-examples/src/main/webapp/js-test/lib/qunit.js
MIT licensed
./wicket-examples/src/main/webapp/jquery-ui-1.10.3.custom.js
Apache 2.0 license
files under ./testing/wicket-arquillian/src/main/java/org/apache/wicket/arquillian/
Something funny happen here - double headers
MIT
./wicket-core/src/main/java/org/apache/wicket/resource/jquery/jquery-3.6.0.js
Also includes Sizzle.js (also MIT) s that should be mentioned in LICENSE as well.
MIT or new BSD license.
./wicket-core/src/test/js/amd/require.js
Public domain?
./wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.js
There is also 3 fonts:
./wicket-examples/src/main/resources/org/apache/wicket/examples/fonts/league-gothic/SIL OFL Font License League Gothic.txt
./wicket-examples/src/main/resources/org/apache/wicket/examples/fonts/source-code-pro/SIL OFL Font License Source Code Pro.txt
./wicket-examples/src/main/resources/org/apache/wicket/examples/fonts/source-sans-pro/SIL OFL Font License - Source Sans Pro.txt
These are problematic as their license is Category B and they cannot be included in a source release.
Finally there a number of files missing license headers so I don't know how they are licensed:
./archetypes/quickstart/src/main/resources/archetype-resources/src/main/java/HomePage.java
./archetypes/quickstart/src/main/resources/archetype-resources/src/main/java/WicketApplication.java
./archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java
./archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/TestHomePage.java
./testing/wicket-common-tests/src/test/java/org/apache/wicket/osgi/OsgiClashingPackagesTest.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationConfiguration.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationContext.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/ConstraintIterator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/DefaultPropertyResolver.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/DefaultValidatorProvider.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/DefaultViolationTranslator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/GroupsModel.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/IPropertyResolver.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/ITagModifier.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/IViolationTranslator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/Property.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/PropertyValidator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SessionLocaleInterpolator.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SizeTagModifier.java
./wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/ValidationModelResolver.java
./wicket-bean-validation/src/test/java/org/apache/wicket/bean/validation/PropertyValidatorRequiredTest.java
./wicket-bean-validation/src/test/java/org/apache/wicket/bean/validation/TestValidatableBean.java
./wicket-bean-validation/src/test/java/org/apache/wicket/bean/validation/ValidationModelResolverTest.java
./wicket-experimental/wicket-metrics/src/main/java/org/apache/wicket/metrics/aspects/WicketFilterInitAspect.java
For the NOTICE file I can't see any reason for any of the the extra text. For example it states " This product includes software from QOS.ch (http://slf4j.org) licensed under the X11 license Copyright (c) 2004-2008 QOS.ch". when a) this is information that should be in LICENSE and bb) QOS.ch is not actually included as far as I can see in the source release. Items that mention BSD and MIT should also be in LICENSE and not NOTICE.
> Releases doesn't comply with ASF policy
> ---------------------------------------
>
> Key: WICKET-6894
> URL: https://issues.apache.org/jira/browse/WICKET-6894
> Project: Wicket
> Issue Type: Bug
> Reporter: Justin Mclean
> Priority: Minor
>
> Contents of LICENSE and NOTICE don't follow the guidance [1] and probably don't comply with ASF policy. In particular:
> - Included 3rd party code license are not listed in LICENSE
> - NOTICE file contains MIT and BSD license information when it shouldn't
> 1. https://infra.apache.org/licensing-howto.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)