[jira] [Commented] (SOLR-9284) The HDFS BlockDirectoryCache should not let it's keysToRelease or names maps grow indefinitely.

["Michael Sun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431842#comment-15431842 ] 

Michael Sun commented on SOLR-9284:
-----------------------------------

Thanks [~markrmiller@gmail.com] for patch. Here is some of my thoughts.

1. In BlockDirectoryCache, the map between name and integer is changed to use Caffeine cache without setting up removal listener. I am not sure if it's correct. If Caffeine cache removes a name in cache, underlying Block Cache needs to delete all blocks related to that name. 
2. There are a few occurrences of System.out.println() in BlockDirectoryCache. It's better to use log.




> The HDFS BlockDirectoryCache should not let it's keysToRelease or names maps grow indefinitely.
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9284
>                 URL: https://issues.apache.org/jira/browse/SOLR-9284
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: hdfs
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 6.2, master (7.0)
>
>         Attachments: SOLR-9284.patch
>
>
> https://issues.apache.org/jira/browse/SOLR-9284



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org