[GitHub] [cassandra] Maxwell-Guo commented on a diff in pull request #2433: CASSANDRA-18615 Add support for USING and index creation by name with CREATE INDEX

["Maxwell-Guo (via GitHub)" <gi...@apache.org>]

Maxwell-Guo commented on code in PR #2433:
URL: https://github.com/apache/cassandra/pull/2433#discussion_r1241015723


##########
src/java/org/apache/cassandra/index/internal/CassandraIndex.java:
##########
@@ -68,6 +68,8 @@
  */
 public abstract class CassandraIndex implements Index
 {
+    public static final String NAME = "cassandra";

Review Comment:
   This is the point I most want to comment on this patch~~~ Because  cassandra vs SAI cannot be aligned conceptually in my mind.  Even native2i is better than cassandra



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org