[GitHub] [accumulo] ctubbsii commented on a change in pull request #2580: Convert defaultTimeoutSeconds() to defaultTimeout()

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2580:
URL: https://github.com/apache/accumulo/pull/2580#discussion_r837679133



##########
File path: test/src/main/java/org/apache/accumulo/harness/AccumuloITBase.java
##########
@@ -111,19 +111,18 @@ public static File createTestDir(String name) {
     }
 
     // if either value is zero, apply a very long timeout (effectively no timeout)
-    int totalTimeoutSeconds = timeoutFactor * defaultTimeoutSeconds();
-    if (totalTimeoutSeconds == 0) {
+    if (timeoutFactor == 0 || defaultTimeoutDuration().isZero()) {

Review comment:
       > or if `defaultTimeout()` was explicitly overridden to return a duration of zero.
   
   Right. That's the case I'm talking about. This shouldn't happen. This should be an error. The only time it should be infinite is if the user says so explicitly with `-Dtimeout.factor=0`. None of our tests should ever have that as a their overridden default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org