You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/05/03 18:23:27 UTC

Re: Review Request 66849: Added missing test expectation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66849/#review202365
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On April 27, 2018, 10:15 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66849/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 10:15 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On master failover the scheduler will get disconnected. Add a test
> expectation for that. This silences a gmock warning.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp 76c169567de6e0ef99c984a673cd69ce7725d6b6 
> 
> 
> Diff: https://reviews.apache.org/r/66849/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Before this patch the fixed tests emits a gmock warning about an unexpected function call, with this patch the warning disappears.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>