[jira] [Commented] (TEPHRA-287) ActionChange.getChangeKey() not implemented correctly

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEPHRA-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460520#comment-16460520 ] 

James Taylor commented on TEPHRA-287:
-------------------------------------

[~poornachandra] - here's a v3 patch with a config option to handle a mix of old and new clients. By default the config is true in which case both the old and new change set keys will be added. Once the config is set to false (after you know that all clients have been upgraded), you can set the config to false in which case only the new change set key is used.

> ActionChange.getChangeKey() not implemented correctly
> -----------------------------------------------------
>
>                 Key: TEPHRA-287
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-287
>             Project: Tephra
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 0.14.0-incubating
>
>         Attachments: TEPHRA-287_v1.patch, TEPHRA-287_v2.patch, TEPHRA-287_v3.patch
>
>
> The ActionChange.getChangeKey() simply concatenates together the row key, family, and qualifier which could lead to incorrect conflicting keys. For example (rowKey='a', family='bc') would conflict with (rowKey='ab', family='c'). A simple fix would be to prefix each part with the byte length of each part.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)