You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/07 11:12:01 UTC
[jira] [Commented] (TOMEE-2328) Cleanup examples maven structure
[ https://issues.apache.org/jira/browse/TOMEE-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712678#comment-16712678 ]
ASF GitHub Bot commented on TOMEE-2328:
---------------------------------------
GitHub user brunobat opened a pull request:
https://github.com/apache/tomee/pull/259
TOMEE-2328 - Cleanup examples maven structure
@ivanjunckes please take a look at this one because I changed the pom of some metrics examples.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brunobat/tomee fix-examples
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomee/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
commit 457035edf57ccf2ef6e1953f201efaa91cf412ae
Author: brunobat <br...@...>
Date: 2018-12-07T10:37:14Z
TOMEE-2328 - remove parent and fix build after that
Signed-off-by: brunobat <br...@gmail.com>
commit 368abd9ec52dacad793b0c486cd9b1c9fdd405fd
Author: brunobat <br...@...>
Date: 2018-12-07T10:42:50Z
TOMEE-2328 - remove parent and fix build after that - mp-metrics-timed
Signed-off-by: brunobat <br...@gmail.com>
commit 8d5fb63510d4a22045f9216c0f8d3f6bad8902cf
Author: brunobat <br...@...>
Date: 2018-12-07T10:57:07Z
TOMEE-2328 - Delete orfaned project. See connector-ear
Signed-off-by: brunobat <br...@gmail.com>
commit 5baf0be677bd336636014861313bef65463bfe88
Author: brunobat <br...@...>
Date: 2018-12-07T11:07:09Z
TOMEE-2328 - Make artifact id match folder and parent module name
Signed-off-by: brunobat <br...@gmail.com>
----
> Cleanup examples maven structure
> --------------------------------
>
> Key: TOMEE-2328
> URL: https://issues.apache.org/jira/browse/TOMEE-2328
> Project: TomEE
> Issue Type: Improvement
> Components: Examples and Documentation
> Affects Versions: 8.0.0-Final
> Reporter: Bruno Baptista
> Priority: Major
> Labels: pull-request-available
>
> Project folder names and artifact ids not always match.
> Some of the sub-projects are absent from the parent modules... They are
> not being built.
> Some of them declare a Parent in the pom.xml with no need and should be
> removed.
> This jira will address these problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)