You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/20 13:11:52 UTC

[GitHub] [spark] offthewall123 commented on pull request #30831: [SPARK-33835][CORE] Refector AbstractCommandBuilder.buildJavaCommand: use firstNonEmpty

offthewall123 commented on pull request #30831:
URL: https://github.com/apache/spark/pull/30831#issuecomment-748606061


   > Minor but fine, if we can deal with none of them being set correctly.
   
   Hi, i have considered of all of them is set uncorrectly, and origin code path don't handle it here, it will throw exception at higher method caller, here just to keep origin code logic, do you think we need deal with it here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org