You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Volkan Yazıcı <vo...@yazi.ci> on 2023/01/31 17:19:25 UTC
[VOTE] Release Apache Log4j Tools 0.2.0
The Apache Log4j Tools 0.2.0 release is now available for voting.
This release contains the following changes:
* Fixed Windows compatibility
* Fixed unreleased directory order in `ChangelogExporter`
* Removed security as a change type from `log4j-changelog`
* Added XSD for `log4j-changelog` XML files
* Added `log4j-changelog-maven-plugin` module
* Renamed `log4j.changelog.exporter.outputDirectory` property to
`log4j.changelog.outputDirectory`
Source repository: https://github.com/apache/logging-log4j-tools
Branch: release/0.2.0
Commit: 2de9c8e0865773050145424237c1840e8296a008
CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4054172734
Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/
Nexus repository:
https://repository.apache.org/content/repositories/orgapachelogging-1097
Signing key: https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index
Please download, test, and cast your votes on the Log4j developers list.
[ ] +1, release the artifacts
[ ] -1, don't release, because...
The vote will remain open for 24 hours (or more if required). All
votes are welcome and we encourage everyone to test the release, but
only the Logging Services PMC votes are officially counted. At least 3
+1 votes and more positive than negative votes are required.
Re: [VOTE] Release Apache Log4j Tools 0.2.0
Posted by Volkan Yazıcı <vo...@yazi.ci>.
Very sharp of you Piotr! Thanks for reviewing the changes thoroughly.
`0.1.0` in the XSD is not a mistake. I used different versions for the
XSD, which resembles more of an API, and the project itself, since
they are independent.
On Tue, Jan 31, 2023 at 11:32 PM Piotr P. Karwasz
<pi...@gmail.com> wrote:
>
> Hi Volkan,
>
> The signatures are correct and the build is reproducible: +1.
>
> On Tue, 31 Jan 2023 at 18:18, Volkan Yazıcı <vo...@yazi.ci> wrote:
> > * Added XSD for `log4j-changelog` XML files
>
> Just a reminder: if the vote passes, the XSD must be published under
> https://logging.apache.org/log4j/changelog-0.1.0.xsd (should probably
> be 0.2.0, but that is no reason to stop the vote).
>
> Piotr
Re: [VOTE] Release Apache Log4j Tools 0.2.0
Posted by "Piotr P. Karwasz" <pi...@gmail.com>.
Hi Volkan,
The signatures are correct and the build is reproducible: +1.
On Tue, 31 Jan 2023 at 18:18, Volkan Yazıcı <vo...@yazi.ci> wrote:
> * Added XSD for `log4j-changelog` XML files
Just a reminder: if the vote passes, the XSD must be published under
https://logging.apache.org/log4j/changelog-0.1.0.xsd (should probably
be 0.2.0, but that is no reason to stop the vote).
Piotr
Re: [VOTE] Release Apache Log4j Tools 0.2.0
Posted by Gary Gregory <ga...@gmail.com>.
A minor note: The tags don't look to me like they are named properly.
In other projects, I see and do, for example:
someartifact-1.0.2-rc1 is the tag for an RC
rel/someartifact-1.0.2 is the tag for the release where infra makes
rel/ tags read-only, at least I'm pretty sure they do.
Having a tag for an RC gives us better traceability IMO.
Gary
On Tue, Jan 31, 2023 at 12:18 PM Volkan Yazıcı <vo...@yazi.ci> wrote:
>
> The Apache Log4j Tools 0.2.0 release is now available for voting.
>
> This release contains the following changes:
>
> * Fixed Windows compatibility
> * Fixed unreleased directory order in `ChangelogExporter`
> * Removed security as a change type from `log4j-changelog`
> * Added XSD for `log4j-changelog` XML files
> * Added `log4j-changelog-maven-plugin` module
> * Renamed `log4j.changelog.exporter.outputDirectory` property to
> `log4j.changelog.outputDirectory`
>
> Source repository: https://github.com/apache/logging-log4j-tools
> Branch: release/0.2.0
> Commit: 2de9c8e0865773050145424237c1840e8296a008
> CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4054172734
> Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1097
> Signing key: https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index
>
> Please download, test, and cast your votes on the Log4j developers list.
>
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
>
> The vote will remain open for 24 hours (or more if required). All
> votes are welcome and we encourage everyone to test the release, but
> only the Logging Services PMC votes are officially counted. At least 3
> +1 votes and more positive than negative votes are required.
Re: [VOTE] Release Apache Log4j Tools 0.2.0
Posted by Volkan Yazıcı <vo...@yazi.ci>.
Adding my +1.
With that, the release passes with 3 binding +1 votes from me, Piotr, and Ralph.
(Gary, I will address your concerns in another thread.)
On Tue, Jan 31, 2023 at 6:19 PM Volkan Yazıcı <vo...@yazi.ci> wrote:
>
> The Apache Log4j Tools 0.2.0 release is now available for voting.
>
> This release contains the following changes:
>
> * Fixed Windows compatibility
> * Fixed unreleased directory order in `ChangelogExporter`
> * Removed security as a change type from `log4j-changelog`
> * Added XSD for `log4j-changelog` XML files
> * Added `log4j-changelog-maven-plugin` module
> * Renamed `log4j.changelog.exporter.outputDirectory` property to
> `log4j.changelog.outputDirectory`
>
> Source repository: https://github.com/apache/logging-log4j-tools
> Branch: release/0.2.0
> Commit: 2de9c8e0865773050145424237c1840e8296a008
> CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4054172734
> Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1097
> Signing key: https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index
>
> Please download, test, and cast your votes on the Log4j developers list.
>
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
>
> The vote will remain open for 24 hours (or more if required). All
> votes are welcome and we encourage everyone to test the release, but
> only the Logging Services PMC votes are officially counted. At least 3
> +1 votes and more positive than negative votes are required.
Re: [VOTE] Release Apache Log4j Tools 0.2.0
Posted by Ralph Goers <ra...@dslextreme.com>.
+1
Verified signature and checksum. Also verified the Maven plugins work with Log4j 2.
One note however, is that the signing key used has not has note been signed by any of us so isn’t exactly trustworthy. We all should sign the key.
Ralph
> On Jan 31, 2023, at 10:19 AM, Volkan Yazıcı <vo...@yazi.ci> wrote:
>
> The Apache Log4j Tools 0.2.0 release is now available for voting.
>
> This release contains the following changes:
>
> * Fixed Windows compatibility
> * Fixed unreleased directory order in `ChangelogExporter`
> * Removed security as a change type from `log4j-changelog`
> * Added XSD for `log4j-changelog` XML files
> * Added `log4j-changelog-maven-plugin` module
> * Renamed `log4j.changelog.exporter.outputDirectory` property to
> `log4j.changelog.outputDirectory`
>
> Source repository: https://github.com/apache/logging-log4j-tools
> Branch: release/0.2.0
> Commit: 2de9c8e0865773050145424237c1840e8296a008
> CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4054172734
> Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1097
> Signing key: https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index
>
> Please download, test, and cast your votes on the Log4j developers list.
>
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
>
> The vote will remain open for 24 hours (or more if required). All
> votes are welcome and we encourage everyone to test the release, but
> only the Logging Services PMC votes are officially counted. At least 3
> +1 votes and more positive than negative votes are required.
Re: [VOTE] Release Apache Log4j Tools 0.2.0
Posted by Gary Gregory <ga...@gmail.com>.
Another minor note: Doubling SHA checksums seems over-the-top in
https://dist.apache.org/repos/dist/dev/logging/log4j/ I'd stick to
512.
Gary
On Tue, Jan 31, 2023 at 12:18 PM Volkan Yazıcı <vo...@yazi.ci> wrote:
>
> The Apache Log4j Tools 0.2.0 release is now available for voting.
>
> This release contains the following changes:
>
> * Fixed Windows compatibility
> * Fixed unreleased directory order in `ChangelogExporter`
> * Removed security as a change type from `log4j-changelog`
> * Added XSD for `log4j-changelog` XML files
> * Added `log4j-changelog-maven-plugin` module
> * Renamed `log4j.changelog.exporter.outputDirectory` property to
> `log4j.changelog.outputDirectory`
>
> Source repository: https://github.com/apache/logging-log4j-tools
> Branch: release/0.2.0
> Commit: 2de9c8e0865773050145424237c1840e8296a008
> CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4054172734
> Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1097
> Signing key: https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index
>
> Please download, test, and cast your votes on the Log4j developers list.
>
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
>
> The vote will remain open for 24 hours (or more if required). All
> votes are welcome and we encourage everyone to test the release, but
> only the Logging Services PMC votes are officially counted. At least 3
> +1 votes and more positive than negative votes are required.
Re: [VOTE] Release Apache Log4j Tools 0.2.0
Posted by Ralph Goers <ra...@dslextreme.com>.
Yes, the tools require Java 11 to build. That should have been obvious by the “Unrecognized option: —add exports” message.
Ralph
> On Feb 2, 2023, at 7:53 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> Warning: I am frustrated.
>
> I'm not going to -1 this but I'm not going to +1 because it is a giant
> pain to build without deleting a bunch of files from the source zip
> file.
>
> There are HIDDEN and not hidden Maven files/folders in there? Why? I
> f*k hate it when downloads try to take over my tooling.
>
> If I unzip the zip file and run what I run every day: 'mvn', it blows up with:
>
> openjdk version "1.8.0_362"
> OpenJDK Runtime Environment (build 1.8.0_362-bre_2023_01_22_03_32-b00)
> OpenJDK 64-Bit Server VM (build 25.362-b00, mixed mode)
> Unrecognized option: --add-exports
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
>
> Lovely. So, duh, I figure I better read the README and see if this
> requires Java 11 instead of 8, so I 'cat README.adoc' and ... I have
> to parse an ADOC file now? Gross. Is that file rendered nicely by
> GitHub like it does for Markdown? It certainly is not nice for humans.
> Oh well.
>
> I don't see anything about what Java version to use so I start
> whacking away, deleting anything like mvnw, a HIDDEN .mvn folder,
> something called .java.version of something. Whack, whack.
>
> Finally, I am allowed to actually run 'mvn clean verify' and it fails with:
>
> [ERROR] Rule 0: org.apache.maven.plugins.enforcer.RequireJavaVersion
> failed with the message:
> Detected JDK Version: 1.8.0-362 is not in the allowed range [11,12).
>
> Ah! Maybe that info was in the readme and I missed it with all the ADOC noise.
>
> So I switch to Java 11 and it builds.
>
> Gary
>
> On Tue, Jan 31, 2023 at 12:18 PM Volkan Yazıcı <vo...@yazi.ci> wrote:
>>
>> The Apache Log4j Tools 0.2.0 release is now available for voting.
>>
>> This release contains the following changes:
>>
>> * Fixed Windows compatibility
>> * Fixed unreleased directory order in `ChangelogExporter`
>> * Removed security as a change type from `log4j-changelog`
>> * Added XSD for `log4j-changelog` XML files
>> * Added `log4j-changelog-maven-plugin` module
>> * Renamed `log4j.changelog.exporter.outputDirectory` property to
>> `log4j.changelog.outputDirectory`
>>
>> Source repository: https://github.com/apache/logging-log4j-tools
>> Branch: release/0.2.0
>> Commit: 2de9c8e0865773050145424237c1840e8296a008
>> CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4054172734
>> Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/
>> Nexus repository:
>> https://repository.apache.org/content/repositories/orgapachelogging-1097
>> Signing key: https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index
>>
>> Please download, test, and cast your votes on the Log4j developers list.
>>
>> [ ] +1, release the artifacts
>> [ ] -1, don't release, because...
>>
>> The vote will remain open for 24 hours (or more if required). All
>> votes are welcome and we encourage everyone to test the release, but
>> only the Logging Services PMC votes are officially counted. At least 3
>> +1 votes and more positive than negative votes are required.
Re: [VOTE] Release Apache Log4j Tools 0.2.0
Posted by Gary Gregory <ga...@gmail.com>.
Warning: I am frustrated.
I'm not going to -1 this but I'm not going to +1 because it is a giant
pain to build without deleting a bunch of files from the source zip
file.
There are HIDDEN and not hidden Maven files/folders in there? Why? I
f*k hate it when downloads try to take over my tooling.
If I unzip the zip file and run what I run every day: 'mvn', it blows up with:
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (build 1.8.0_362-bre_2023_01_22_03_32-b00)
OpenJDK 64-Bit Server VM (build 25.362-b00, mixed mode)
Unrecognized option: --add-exports
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Lovely. So, duh, I figure I better read the README and see if this
requires Java 11 instead of 8, so I 'cat README.adoc' and ... I have
to parse an ADOC file now? Gross. Is that file rendered nicely by
GitHub like it does for Markdown? It certainly is not nice for humans.
Oh well.
I don't see anything about what Java version to use so I start
whacking away, deleting anything like mvnw, a HIDDEN .mvn folder,
something called .java.version of something. Whack, whack.
Finally, I am allowed to actually run 'mvn clean verify' and it fails with:
[ERROR] Rule 0: org.apache.maven.plugins.enforcer.RequireJavaVersion
failed with the message:
Detected JDK Version: 1.8.0-362 is not in the allowed range [11,12).
Ah! Maybe that info was in the readme and I missed it with all the ADOC noise.
So I switch to Java 11 and it builds.
Gary
On Tue, Jan 31, 2023 at 12:18 PM Volkan Yazıcı <vo...@yazi.ci> wrote:
>
> The Apache Log4j Tools 0.2.0 release is now available for voting.
>
> This release contains the following changes:
>
> * Fixed Windows compatibility
> * Fixed unreleased directory order in `ChangelogExporter`
> * Removed security as a change type from `log4j-changelog`
> * Added XSD for `log4j-changelog` XML files
> * Added `log4j-changelog-maven-plugin` module
> * Renamed `log4j.changelog.exporter.outputDirectory` property to
> `log4j.changelog.outputDirectory`
>
> Source repository: https://github.com/apache/logging-log4j-tools
> Branch: release/0.2.0
> Commit: 2de9c8e0865773050145424237c1840e8296a008
> CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4054172734
> Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1097
> Signing key: https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index
>
> Please download, test, and cast your votes on the Log4j developers list.
>
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
>
> The vote will remain open for 24 hours (or more if required). All
> votes are welcome and we encourage everyone to test the release, but
> only the Logging Services PMC votes are officially counted. At least 3
> +1 votes and more positive than negative votes are required.