Re: [PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #417:
URL: https://github.com/apache/spark-kubernetes-operator/pull/417#discussion_r2778388161


##########
build-tools/helm/spark-kubernetes-operator/values.yaml:
##########
@@ -61,9 +61,14 @@ operatorDeployment:
         livenessProbe:
           periodSeconds: 10
           initialDelaySeconds: 30
+          failureThreshold: 1
+          timeoutSeconds: 1
         startupProbe:
           failureThreshold: 30
           periodSeconds: 10
+        readinessProbe:
+          failureThreshold: 1

Review Comment:
   Also, this PR introduces an inconsistency for `readinessProbe.failureThreahold`. Here, this PR uses 1 while the default is introduced by 30.
   
   {{- default 30 .Values.operatorDeployment.operatorPod.operatorContainer.probes.readinessProbe.failureThreshold }}



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org