You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/04 11:43:25 UTC

[GitHub] [airflow] potiuk edited a comment on pull request #12802: Compile static assets when running setup.py.

potiuk edited a comment on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738738908


   > Sorry, yes, I didn't sleep well. I meant "fail the `webserver` command"
   
   Faillng webserver is indeed smth we should do. Also maybe a little more than that. We should fail the webserver when the assets are not generated using the current sources (need regeneration). This happened several times in breeze environment that people complained about not working webserver and the reason was that after James's improvements the old "compiled" assets were wrong and you needed to re-compile them,
   
   This could be as easy as making hash of all the "sources" and storing it at compile time and comparing it. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org