You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/07 20:01:44 UTC
[GitHub] [nifi-minifi-cpp] achristianson opened a new pull request #834: MINIFICPP-1282 Use GNUInstallDirs for more reliable determination of installed lib/lib64 directories
achristianson opened a new pull request #834:
URL: https://github.com/apache/nifi-minifi-cpp/pull/834
Use `GNUInstallDirs` for more reliable determination of installed lib/lib64 directories.
This fixes a bug :beetle: I ran into when attempting to build on Arch Linux. According to https://cmake.org/cmake/help/v3.4/module/GNUInstallDirs.html `GNUInstallDirs` `CMAKE_INSTALL_LIBDIR` will give the correct dir: "object code libraries (lib or lib64 or lib/<multiarch-tuple> on Debian)"
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] achristianson commented on pull request #834: MINIFICPP-1282 Use GNUInstallDirs for more reliable determination of installed lib/lib64 directories
Posted by GitBox <gi...@apache.org>.
achristianson commented on pull request #834:
URL: https://github.com/apache/nifi-minifi-cpp/pull/834#issuecomment-655534531
Thanks for the review/merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #834: MINIFICPP-1282 Use GNUInstallDirs for more reliable determination of installed lib/lib64 directories
Posted by GitBox <gi...@apache.org>.
arpadboda commented on pull request #834:
URL: https://github.com/apache/nifi-minifi-cpp/pull/834#issuecomment-655434518
Looks good to me.
@szaszm do you have any concerns?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #834: MINIFICPP-1282 Use GNUInstallDirs for more reliable determination of installed lib/lib64 directories
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #834:
URL: https://github.com/apache/nifi-minifi-cpp/pull/834
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org