You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2023/05/25 14:08:28 UTC

[shardingsphere] branch master updated: Remove push FinishedRecord at MySQL increment dumper (#25897)

This is an automated email from the ASF dual-hosted git repository.

zhonghongsheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 596e3194a7f Remove push FinishedRecord at MySQL increment dumper (#25897)
596e3194a7f is described below

commit 596e3194a7f663c5ca3641bdabaadbf56d807ded
Author: Xinze Guo <10...@users.noreply.github.com>
AuthorDate: Thu May 25 22:08:18 2023 +0800

    Remove push FinishedRecord at MySQL increment dumper (#25897)
---
 .../data/pipeline/mysql/ingest/MySQLIncrementalDumper.java             | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/MySQLIncrementalDumper.java b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/MySQLIncrementalDumper.java
index 71f7c8f0f55..793de1271ae 100644
--- a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/MySQLIncrementalDumper.java
+++ b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/MySQLIncrementalDumper.java
@@ -25,11 +25,9 @@ import org.apache.shardingsphere.data.pipeline.api.datasource.config.yaml.YamlJd
 import org.apache.shardingsphere.data.pipeline.api.executor.AbstractLifecycleExecutor;
 import org.apache.shardingsphere.data.pipeline.api.ingest.channel.PipelineChannel;
 import org.apache.shardingsphere.data.pipeline.api.ingest.dumper.IncrementalDumper;
-import org.apache.shardingsphere.data.pipeline.api.ingest.position.FinishedPosition;
 import org.apache.shardingsphere.data.pipeline.api.ingest.position.IngestPosition;
 import org.apache.shardingsphere.data.pipeline.api.ingest.record.Column;
 import org.apache.shardingsphere.data.pipeline.api.ingest.record.DataRecord;
-import org.apache.shardingsphere.data.pipeline.api.ingest.record.FinishedRecord;
 import org.apache.shardingsphere.data.pipeline.api.ingest.record.PlaceholderRecord;
 import org.apache.shardingsphere.data.pipeline.api.ingest.record.Record;
 import org.apache.shardingsphere.data.pipeline.api.metadata.ActualTableName;
@@ -107,7 +105,6 @@ public final class MySQLIncrementalDumper extends AbstractLifecycleExecutor impl
             }
             handleEvents(events);
         }
-        channel.pushRecords(Collections.singletonList(new FinishedRecord(new FinishedPosition())));
     }
     
     private void handleEvents(final List<AbstractBinlogEvent> events) {