[GitHub] [incubator-hudi] umehrot2 commented on a change in pull request #1001: [HUDI-325] Fix Hive partition error for updated HDFS Hudi table

[GitBox <gi...@apache.org>]

umehrot2 commented on a change in pull request #1001: [HUDI-325] Fix Hive partition error for updated HDFS Hudi table
URL: https://github.com/apache/incubator-hudi/pull/1001#discussion_r343943359
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/FSUtils.java
 ##########
 @@ -532,6 +532,13 @@ public static Path getPartitionPath(Path basePath, String partitionPath) {
     return ((partitionPath == null) || (partitionPath.isEmpty())) ? basePath : new Path(basePath, partitionPath);
   }
 
+  /**
+   * Get file URI path (e.g. hdfs://ip-address:8020:/<file absolute path>)
+   */
+  public static String getURIPath(FileSystem fs, Path filePath) {
 
 Review comment:
   **[Trivial]** `filePath =>  path` as it is more generic. Also what you are actually passing to this function is not a file's path, but a partitions path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services