Re: svn commit: r387938 - /apr/apr-util/branches/0.9.x/buildconf

[Joe Orton <jo...@redhat.com>]

On Wed, Mar 22, 2006 at 08:50:48PM -0000, William Rowe wrote:
> Author: wrowe
> Date: Wed Mar 22 12:50:46 2006
> New Revision: 387938
> 
> URL: http://svn.apache.org/viewcvs?rev=387938&view=rev
> Log:
> 
>   Cleanup autom4te cruft
> 
> Modified:
>     apr/apr-util/branches/0.9.x/buildconf
...
>  #
>  # If Expat has been bundled, then go and configure the thing
> +# and then remove autoconf cache
>  #
>  if [ -f xml/expat/buildconf.sh ]; then
>    echo "Invoking xml/expat/buildconf.sh ..."
> -  (cd xml/expat; ./buildconf.sh)
> +  (cd xml/expat; ./buildconf.sh; rm -rf autom4te*.cache)
>  fi

> -
> -# Remove autoconf cache
> -rm -rf autom4te*.cache

That line was suppoesd to be there - the tarball you rolled now includes 
an unnecessary "autom4te.cache" directory.

joe

Re: svn commit: r387938 - /apr/apr-util/branches/0.9.x/buildconf

[Jean-frederic Clere <jf...@gmail.com>]

William A. Rowe, Jr. wrote:

> Joe Orton wrote:
>
>> On Wed, Mar 22, 2006 at 08:50:48PM -0000, William Rowe wrote:
>>
>>> -
>>> -# Remove autoconf cache
>>> -rm -rf autom4te*.cache
>>
>>
>> That line was suppoesd to be there - the tarball you rolled now 
>> includes an unnecessary "autom4te.cache" directory.
>
>
> Outch you are right... I see we pre-and-post remove the thing.  
> Recommitting,
> and if I don't see any other feedback before the 24 hour mark I'll re 
> T&R...
> Version numbers are cheap.
>
> The question is, do we *also* need to _pre_remove autom4te*.cache in 
> the expat
> tree?

Well, if someone runs "buildconf" and have a different version of 
automake/autoconf/m4 the created configure will not work (I remember 
spending a lot of time after scp -rp apr-util ... and rm -rf 
autom4te*.cache fixed the problem).

>
> Bill
>

Re: svn commit: r387938 - /apr/apr-util/branches/0.9.x/buildconf

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

Joe Orton wrote:
> On Wed, Mar 22, 2006 at 08:50:48PM -0000, William Rowe wrote:
> 
>>-
>>-# Remove autoconf cache
>>-rm -rf autom4te*.cache
> 
> That line was suppoesd to be there - the tarball you rolled now includes 
> an unnecessary "autom4te.cache" directory.

Outch you are right... I see we pre-and-post remove the thing.  Recommitting,
and if I don't see any other feedback before the 24 hour mark I'll re T&R...
Version numbers are cheap.

The question is, do we *also* need to _pre_remove autom4te*.cache in the expat
tree?

Bill