You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tvalentyn (via GitHub)" <gi...@apache.org> on 2026/10/14 22:55:48 UTC
[PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
tvalentyn opened a new pull request, #40596:
URL: https://github.com/apache/beam/pull/40596
Fix a flake that happened in https://github.com/apache/beam/pull/40000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey merged PR #40596:
URL: https://github.com/apache/beam/pull/40596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #40596:
URL: https://github.com/apache/beam/pull/40596#issuecomment-6220955387
_create_extra_file did a bit more than what was written in its name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #40596:
URL: https://github.com/apache/beam/pull/40596#issuecomment-6180316989
R: @bvolpato
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40596:
URL: https://github.com/apache/beam/pull/40596#issuecomment-6221574602
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40596?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.94%. Comparing base ([`76f6e6d`](https://app.codecov.io/gh/apache/beam/commit/76f6e6d7c0c1b2ce582c73d068ad9260cf15c5f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b4aa168`](https://app.codecov.io/gh/apache/beam/commit/b4aa16819c6ad8bdb8e62e2d70dafa02b8acb534?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 210 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40596 +/- ##
=============================================
+ Coverage 56.16% 79.94% +23.77%
=============================================
Files 1124 488 -636
Lines 178336 82556 -95780
Branches 1489 0 -1489
=============================================
- Hits 100170 65997 -34173
+ Misses 75645 16559 -59086
+ Partials 2521 0 -2521
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40596/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/40596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java](https://app.codecov.io/gh/apache/beam/pull/40596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [python](https://app.codecov.io/gh/apache/beam/pull/40596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.94% <ø> (+0.38%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40596?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #40596:
URL: https://github.com/apache/beam/pull/40596#issuecomment-6220821268
oops, yes, I assumed it was preexisting
```
11. [unknown] 1 test(s)
suite Python tests / Python Unit Tests (macos-latest, 3.13, py313)
cause BeamAssertException: Failed assert: ['/Users/runner/work/beam/beam/sdks/python/target/.tox/py313-macos/tmp/tmp_wi8zfq_/tmp5aikcszw', '/Users/runner/work/beam/beam/sdks/python/target/.tox/py313-macos/tmp/tmp_wi8zfq_/tmp5a
why no rule matched — needs a human
test MatchContinuouslyTest.test_without_deduplication (0s)
apache_beam/runners/common.py:914 in apache_beam.runners.common.PerWindowInvoker.invoke_process
chain BeamAssertException → BeamAssertException
log https://github.com/apache/beam/actions/runs/38650898197/job/116149129946 (line ~19434)
── excerpt ──
| [gw4] darwin -- Python 3.13.15 /Users/runner/work/beam/beam/sdks/python/target/.tox/py313-macos/bin/python
| > return self.do_fn_invoker.invoke_process(windowed_value)
| apache_beam/runners/common.py:1512:
| _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
| apache_beam/runners/common.py:914: in apache_beam.runners.common.PerWindowInvoker.invoke_process
| self._invoke_process_per_window(
| apache_beam/runners/common.py:1059: in apache_beam.runners.common.PerWindowInvoker._invoke_process_per_window
| self.process_method(*args_for_process, **kwargs_for_process),
| target/.tox/py313-macos/lib/python3.13/site-packages/apache_beam/transforms/core.py:2128: in <lambda>
| wrapper = lambda x, *args, **kwargs: [fn(x, *args, **kwargs)]
| ^^^^^^^^^^^^^^^^^^^^^^
| _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
| actual = [FileMetadata(/Users/runner/work/beam/beam/sdks/python/target/.tox/py313-macos/tmp/tmp_wi8zfq_/tmp5aikcszw, 0, 1792019...ta(/Users/runner/work/beam/beam/sdks/python/target/.tox/py313-macos/tm
| equals_fn = <function row_namedtuple_equals_fn at 0x119868e00>
| def _equal(actual, equals_fn=equals_fn):
| expected_list = list(expected)
| # Try to compare actual and expected by sorting. This fails with a
| # TypeError in Python 3 if different types are present in the same
| # collection. It can also raise false negatives for types that don't have
| # a deterministic sort order, like pyarrow Tables as of 0.14.1
| if not equals_fn:
| equals_fn = row_namedtuple_equals_fn
| try:
| sorted_expected = sorted(expected)
| sorted_actual = sorted(actual)
| … 15 more line(s) — open the log above
`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40596:
URL: https://github.com/apache/beam/pull/40596#issuecomment-6220581209
Assigning reviewers:
R: @jrmccluskey for label python.
Backup reviewer: damccorm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)
This pull request likely touches a core component ("core" label). Please review with scrutiny.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40596:
URL: https://github.com/apache/beam/pull/40596#issuecomment-6180328412
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove a race with another file write that is not essential to test presence of duplicates. [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #40596:
URL: https://github.com/apache/beam/pull/40596#issuecomment-6220573993
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org