[GitHub] spark pull request: SPARK-1890 and SPARK-1891- add admin and modif...

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1196#discussion_r14941021
  
    --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
    @@ -169,18 +192,43 @@ private[spark] class SecurityManager(sparkConf: SparkConf) extends Logging {
         )
       }
     
    -  private[spark] def setViewAcls(defaultUsers: Seq[String], allowedUsers: String) {
    -    viewAcls = (defaultUsers ++ allowedUsers.split(',')).map(_.trim()).filter(!_.isEmpty).toSet 
    +  /**
    +   * Split a comma separated String, filter out any empty items, and return a Set of strings
    +   */
    +  private def stringToSet(list: String): Set[String] = {
    +    (list.split(',')).map(_.trim()).filter(!_.isEmpty).toSet
    --- End diff --
    
    removed a couple.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---