[GitHub] [beam] kennknowles opened a new issue, #18017: StateTags$CombiningValueStateTag inherits equals from super class but without incorporating its state

[GitBox <gi...@apache.org>]

kennknowles opened a new issue, #18017:
URL: https://github.com/apache/beam/issues/18017

   [FindBugs EQ_DOESNT_OVERRIDE_EQUALS](https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L555): Class doesn't override equals in superclass
   
   Applies to: [StateTags$CombiningValueStateTag](https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java#L344). CombiningValueStateTag inherits its equals implementation from its parent class, KeyedCombiningValueStateTag. CombiningValueStateTag has additional fields which are not included in the equality implementation, which may be incorrect.
   
   This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml](https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml) and verify the build passes.
   
   Imported from Jira [BEAM-421](https://issues.apache.org/jira/browse/BEAM-421). Original Jira may contain additional context.
   Reported by: swegner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org