You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Nico Verwer (JIRA)" <ji...@apache.org> on 2010/08/13 16:38:16 UTC

[jira] Created: (COCOON-2298) IncludeTransformer does not handle multi-valued parameters

IncludeTransformer does not handle multi-valued parameters
----------------------------------------------------------

                 Key: COCOON-2298
                 URL: https://issues.apache.org/jira/browse/COCOON-2298
             Project: Cocoon
          Issue Type: Bug
          Components: * Cocoon Core
    Affects Versions: 2.1.11
            Reporter: Nico Verwer


When you pass multivalued parameters to org.apache.cocoon.transformation.IncludeTransformer, like:
   <ci:parameter name="foo" value="bar"/>
   <ci:parameter name="foo" value="baz"/>
only the last gets passed in the request made by IncludeTransformer. This is because parameters are stored in a Map.

HTTP specifies that multi-valued parameters are possible, or rather it does not forbid them. So the query-string "?foo=bar&foo=baz" is perfectly legal.

The patch changes the way IncludeTransformer handles this case, so that multi-valued parameters are handled correctly. The NetUtils.parameterize() method, used by IncludeTransformer, was already prepared for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2298) IncludeTransformer does not handle multi-valued parameters

Posted by "Nico Verwer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nico Verwer updated COCOON-2298:
--------------------------------

    Attachment: IncludeTransformer.patch

This patch makes IncludeTransformer handle multi-valued parameters correctly.

> IncludeTransformer does not handle multi-valued parameters
> ----------------------------------------------------------
>
>                 Key: COCOON-2298
>                 URL: https://issues.apache.org/jira/browse/COCOON-2298
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.11
>            Reporter: Nico Verwer
>         Attachments: IncludeTransformer.patch
>
>
> When you pass multivalued parameters to org.apache.cocoon.transformation.IncludeTransformer, like:
>    <ci:parameter name="foo" value="bar"/>
>    <ci:parameter name="foo" value="baz"/>
> only the last gets passed in the request made by IncludeTransformer. This is because parameters are stored in a Map.
> HTTP specifies that multi-valued parameters are possible, or rather it does not forbid them. So the query-string "?foo=bar&foo=baz" is perfectly legal.
> The patch changes the way IncludeTransformer handles this case, so that multi-valued parameters are handled correctly. The NetUtils.parameterize() method, used by IncludeTransformer, was already prepared for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.