[jira] [Resolved] (RANGER-1444) Do some code improvement in security admin module

["Qiang Zhang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/RANGER-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Qiang Zhang resolved RANGER-1444.
---------------------------------
    Resolution: Fixed

> Do some code improvement in security admin module
> -------------------------------------------------
>
>                 Key: RANGER-1444
>                 URL: https://issues.apache.org/jira/browse/RANGER-1444
>             Project: Ranger
>          Issue Type: Bug
>          Components: admin
>    Affects Versions: 1.0.0
>            Reporter: Qiang Zhang
>            Assignee: Qiang Zhang
>             Fix For: 1.0.0
>
>
> 1. There are some duplicate codes in method mapXXPortalUserToVXPortalUserForDefaultAccount.
> {code}
> userProfile.setLoginId(user.getLoginId());
> userProfile.setEmailAddress(user.getEmailAddress());
> userProfile.setStatus(user.getStatus());
> userProfile.setUserRoleList(new ArrayList<String>());
> userProfile.setId(user.getId());
> userProfile.setFirstName(user.getFirstName());
> userProfile.setLastName(user.getLastName());
> userProfile.setPublicScreenName(user.getPublicScreenName());
> userProfile.setEmailAddress(user.getEmailAddress());
> {code}
> We set the email address twice.
> 2. We have already checked if sess is null, so don't need to check it in below logic.
> {code}
> UserSessionBase sess = ContextUtil.getCurrentUserSession();
> if (sess != null) {
> 	if (sess != null && sess.isUserAdmin() || sess.isKeyAdmin()) {
> 		return;
> 	}
> 	if (sess.getXXPortalUser().getId().equals(gjUser.getId())) {
> 		return;
> 	}
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)