You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/17 04:16:47 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #7535:
Disabling flask-talisman by default
mistercrunch opened a new pull request #7535: Disabling flask-talisman by default
URL: https://github.com/apache/incubator-superset/pull/7535
### CATEGORY
Choose one
- [x] Bug Fix
### SUMMARY
flask-talisman was enabled recently and while it may be virtuous in some
cases, it seems to break things out of the box.
Locally and in dev mode, upon my first redirect it sends to HTTPS and
things it crashes.
I think it should be opt-in, maybe we can recommend turning this on in
production in the docs?
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="832" alt="Screen Shot 2019-05-16 at 9 16 24 PM" src="https://user-images.githubusercontent.com/487433/57902807-e43c7f00-781f-11e9-9eb4-11b2c8e0d81a.png">
<img width="743" alt="Screen Shot 2019-05-16 at 9 16 10 PM" src="https://user-images.githubusercontent.com/487433/57902808-e43c7f00-781f-11e9-8e22-a7c2c8b962c4.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org