You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by "Tzu-Li (Gordon) Tai" <tz...@apache.org> on 2018/03/14 10:26:48 UTC

[VOTE] Release 1.3.3, release candidate #2

Hi everyone,

Please review and vote on release candidate #2 for Flink 1.3.3, as follows:  
[ ] +1, Approve the release  
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:  
* JIRA release notes [1],  
* the official Apache source release and binary convenience releases to be deployed to dist.apache.org [2], which are signed with the key with fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],  
* all artifacts to be deployed to the Maven Central Repository [4],  
* source code branch “release-1.3.3-rc2” [5],  
* website pull request listing the new release [6].  
* A complete list of all new commits in release-1.3.3-rc2, since release-1.3.2 [7]

This release candidate contains fixes for only the following issues:
[FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase
[FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.checkpointsMatch()
[FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in infinite loop
[FLINK-7783] Don’t always remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()

Since the last candidate was cancelled only due to incorrect binaries in the source artifacts, I think we can also have a shorter voting period for RC2.

Please test the release and vote for the release candidate before Thursday (March 15th), 7pm CET. 
It is adopted by majority approval, with at least 3 PMC affirmative votes.

Please let me know if you disagree with the shortened voting time.

Thanks,  
Gordon

[1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12341142
[2] http://people.apache.org/~tzulitai/flink-1.3.3-rc2/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1151
[5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=shortlog;h=refs/heads/release-1.3.3-rc2
[6] https://github.com/apache/flink-web/pull/104
[7] 
- 90559b5413455d9d0f2b61c389a60e26e5c87800 [hotfix] Properly delete temp flink dir in create_source_release.sh
- 99c0353a34c09af5bedb73f525f691dd7e78fcdd [hotfix] Ensure pristine release in tools/releasing/create_source_release.sh
- b2437f87e361a822adbad6f1c3e6eb14eeeb09fa [FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase
- 1432092f29c548c55af562ff7b4a7973fedd2e22 [FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.checkpointsMatch()
- df37d7acfea10a5ca3186f3c53294f2050758627 [FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in infinite loop
- f69bdf207b92ca47a5ce3e29f6ec7193ed17ec72 [FLINK-7783] Don’t always remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()


Re: [VOTE] Release 1.3.3, release candidate #2

Posted by "Tzu-Li (Gordon) Tai" <tz...@apache.org>.
+1

- checked hashes and signatures
- built from staged source artifact
- ran state machine job chaos monkey test on AWS EMR
- ran quickstarts

I also agree that we do not need to cancel the RC because of the unintended PythonPlanBinderTest commit.

Cheers,
Gordon

On 15 March 2018 at 11:08:30 PM, Fabian Hueske (fhueske@gmail.com) wrote:

+1  

- checked hashes and signatures  
- build from src.tgz with unit tests (mvn clean package)  
- checked commits for dependency changes and didn't find any  

Thanks, Fabian  

2018-03-15 14:06 GMT+01:00 Chesnay Schepler <ch...@apache.org>:  

> Given that the commit only affects a test I'd be in favor of continuing  
> the release process and updating the release notes.  
>  
>  
> On 15.03.2018 14:01, Timo Walther wrote:  
>  
>> +1  
>>  
>> - built and run tests locally  
>> - run some training exercises locally  
>> - looked over the commits  
>>  
>> I found one minor thing that should be mentioned. It seems that there is  
>> one unintended commit in the release:  
>>  
>> 2455df962c76d20f1c07a57d6ed0118d1d1a067c [FLINK-7283][python] fix  
>> PythonPlanBinderTest issues with python paths  
>>  
>> It only affects a test so I think we should not cancel the release  
>> because of that but update the release notes and the Jira issue.  
>>  
>> What do you think?  
>>  
>> Regards,  
>> Timo  
>>  
>> Am 15.03.18 um 10:10 schrieb Chesnay Schepler:  
>>  
>>> +1  
>>>  
>>> * verified that compilation works  
>>> * ran a few test examples against a local cluster  
>>> * src artifact contains no binaries  
>>> * verified signatures  
>>>  
>>> On 14.03.2018 21:49, Ted Yu wrote:  
>>>  
>>>> +1  
>>>>  
>>>> Ran the following command - passed:  
>>>>  
>>>> mvn clean package -Pjdk8  
>>>>  
>>>> On Wed, Mar 14, 2018 at 3:26 AM, Tzu-Li (Gordon) Tai <  
>>>> tzulitai@apache.org>  
>>>> wrote:  
>>>>  
>>>> Hi everyone,  
>>>>>  
>>>>> Please review and vote on release candidate #2 for Flink 1.3.3, as  
>>>>> follows:  
>>>>> [ ] +1, Approve the release  
>>>>> [ ] -1, Do not approve the release (please provide specific comments)  
>>>>>  
>>>>> The complete staging area is available for your review, which includes:  
>>>>> * JIRA release notes [1],  
>>>>> * the official Apache source release and binary convenience releases  
>>>>> to be  
>>>>> deployed to dist.apache.org [2], which are signed with the key with  
>>>>> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],  
>>>>> * all artifacts to be deployed to the Maven Central Repository [4],  
>>>>> * source code branch “release-1.3.3-rc2” [5],  
>>>>> * website pull request listing the new release [6].  
>>>>> * A complete list of all new commits in release-1.3.3-rc2, since  
>>>>> release-1.3.2 [7]  
>>>>>  
>>>>> This release candidate contains fixes for only the following issues:  
>>>>> [FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase  
>>>>> [FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.  
>>>>> checkpointsMatch()  
>>>>> [FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in  
>>>>> infinite loop  
>>>>> [FLINK-7783] Don’t always remove checkpoints in  
>>>>> ZooKeeperCompletedCheckpointStore#recover()  
>>>>>  
>>>>> Since the last candidate was cancelled only due to incorrect binaries  
>>>>> in  
>>>>> the source artifacts, I think we can also have a shorter voting period  
>>>>> for  
>>>>> RC2.  
>>>>>  
>>>>> Please test the release and vote for the release candidate before  
>>>>> Thursday  
>>>>> (March 15th), 7pm CET.  
>>>>> It is adopted by majority approval, with at least 3 PMC affirmative  
>>>>> votes.  
>>>>>  
>>>>> Please let me know if you disagree with the shortened voting time.  
>>>>>  
>>>>> Thanks,  
>>>>> Gordon  
>>>>>  
>>>>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?  
>>>>> projectId=12315522&version=12341142  
>>>>> [2] http://people.apache.org/~tzulitai/flink-1.3.3-rc2/  
>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS  
>>>>> [4] https://repository.apache.org/content/repositories/orgapache  
>>>>> flink-1151  
>>>>> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=  
>>>>> shortlog;h=refs/heads/release-1.3.3-rc2  
>>>>> [6] https://github.com/apache/flink-web/pull/104  
>>>>> [7]  
>>>>> - 90559b5413455d9d0f2b61c389a60e26e5c87800 [hotfix] Properly delete  
>>>>> temp  
>>>>> flink dir in create_source_release.sh  
>>>>> - 99c0353a34c09af5bedb73f525f691dd7e78fcdd [hotfix] Ensure pristine  
>>>>> release in tools/releasing/create_source_release.sh  
>>>>> - b2437f87e361a822adbad6f1c3e6eb14eeeb09fa [FLINK-8487] Verify  
>>>>> ZooKeeper  
>>>>> checkpoint store behaviour with ITCase  
>>>>> - 1432092f29c548c55af562ff7b4a7973fedd2e22 [FLINK-8890] Compare  
>>>>> checkpoints with order in CompletedCheckpoint.checkpointsMatch()  
>>>>> - df37d7acfea10a5ca3186f3c53294f2050758627 [FLINK-8807] Fix  
>>>>> ZookeeperCompleted checkpoint store can get stuck in infinite loop  
>>>>> - f69bdf207b92ca47a5ce3e29f6ec7193ed17ec72 [FLINK-7783] Don’t always  
>>>>> remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()  
>>>>>  
>>>>>  
>>>>>  
>>  
>>  
>  

Re: [VOTE] Release 1.3.3, release candidate #2

Posted by Fabian Hueske <fh...@gmail.com>.
+1

- checked hashes and signatures
- build from src.tgz with unit tests (mvn clean package)
- checked commits for dependency changes and didn't find any

Thanks, Fabian

2018-03-15 14:06 GMT+01:00 Chesnay Schepler <ch...@apache.org>:

> Given that the commit only affects a test I'd be in favor of continuing
> the release process and updating the release notes.
>
>
> On 15.03.2018 14:01, Timo Walther wrote:
>
>> +1
>>
>> - built and run tests locally
>> - run some training exercises locally
>> - looked over the commits
>>
>> I found one minor thing that should be mentioned. It seems that there is
>> one unintended commit in the release:
>>
>> 2455df962c76d20f1c07a57d6ed0118d1d1a067c [FLINK-7283][python] fix
>> PythonPlanBinderTest issues with python paths
>>
>> It only affects a test so I think we should not cancel the release
>> because of that but update the release notes and the Jira issue.
>>
>> What do you think?
>>
>> Regards,
>> Timo
>>
>> Am 15.03.18 um 10:10 schrieb Chesnay Schepler:
>>
>>> +1
>>>
>>> * verified that compilation works
>>> * ran a few test examples against a local cluster
>>> * src artifact contains no binaries
>>> * verified signatures
>>>
>>> On 14.03.2018 21:49, Ted Yu wrote:
>>>
>>>> +1
>>>>
>>>> Ran the following command - passed:
>>>>
>>>> mvn clean package -Pjdk8
>>>>
>>>> On Wed, Mar 14, 2018 at 3:26 AM, Tzu-Li (Gordon) Tai <
>>>> tzulitai@apache.org>
>>>> wrote:
>>>>
>>>> Hi everyone,
>>>>>
>>>>> Please review and vote on release candidate #2 for Flink 1.3.3, as
>>>>> follows:
>>>>> [ ] +1, Approve the release
>>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>>
>>>>> The complete staging area is available for your review, which includes:
>>>>> * JIRA release notes [1],
>>>>> * the official Apache source release and binary convenience releases
>>>>> to be
>>>>> deployed to dist.apache.org [2], which are signed with the key with
>>>>> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],
>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>>> * source code branch “release-1.3.3-rc2” [5],
>>>>> * website pull request listing the new release [6].
>>>>> * A complete list of all new commits in release-1.3.3-rc2, since
>>>>> release-1.3.2 [7]
>>>>>
>>>>> This release candidate contains fixes for only the following issues:
>>>>> [FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase
>>>>> [FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.
>>>>> checkpointsMatch()
>>>>> [FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in
>>>>> infinite loop
>>>>> [FLINK-7783] Don’t always remove checkpoints in
>>>>> ZooKeeperCompletedCheckpointStore#recover()
>>>>>
>>>>> Since the last candidate was cancelled only due to incorrect binaries
>>>>> in
>>>>> the source artifacts, I think we can also have a shorter voting period
>>>>> for
>>>>> RC2.
>>>>>
>>>>> Please test the release and vote for the release candidate before
>>>>> Thursday
>>>>> (March 15th), 7pm CET.
>>>>> It is adopted by majority approval, with at least 3 PMC affirmative
>>>>> votes.
>>>>>
>>>>> Please let me know if you disagree with the shortened voting time.
>>>>>
>>>>> Thanks,
>>>>> Gordon
>>>>>
>>>>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>>>> projectId=12315522&version=12341142
>>>>> [2] http://people.apache.org/~tzulitai/flink-1.3.3-rc2/
>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>>> [4] https://repository.apache.org/content/repositories/orgapache
>>>>> flink-1151
>>>>> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=
>>>>> shortlog;h=refs/heads/release-1.3.3-rc2
>>>>> [6] https://github.com/apache/flink-web/pull/104
>>>>> [7]
>>>>> - 90559b5413455d9d0f2b61c389a60e26e5c87800 [hotfix] Properly delete
>>>>> temp
>>>>> flink dir in create_source_release.sh
>>>>> - 99c0353a34c09af5bedb73f525f691dd7e78fcdd [hotfix] Ensure pristine
>>>>> release in tools/releasing/create_source_release.sh
>>>>> - b2437f87e361a822adbad6f1c3e6eb14eeeb09fa [FLINK-8487] Verify
>>>>> ZooKeeper
>>>>> checkpoint store behaviour with ITCase
>>>>> - 1432092f29c548c55af562ff7b4a7973fedd2e22 [FLINK-8890] Compare
>>>>> checkpoints with order in CompletedCheckpoint.checkpointsMatch()
>>>>> - df37d7acfea10a5ca3186f3c53294f2050758627 [FLINK-8807] Fix
>>>>> ZookeeperCompleted checkpoint store can get stuck in infinite loop
>>>>> - f69bdf207b92ca47a5ce3e29f6ec7193ed17ec72 [FLINK-7783] Don’t always
>>>>> remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()
>>>>>
>>>>>
>>>>>
>>
>>
>

Re: [VOTE] Release 1.3.3, release candidate #2

Posted by Chesnay Schepler <ch...@apache.org>.
Given that the commit only affects a test I'd be in favor of continuing 
the release process and updating the release notes.

On 15.03.2018 14:01, Timo Walther wrote:
> +1
>
> - built and run tests locally
> - run some training exercises locally
> - looked over the commits
>
> I found one minor thing that should be mentioned. It seems that there 
> is one unintended commit in the release:
>
> 2455df962c76d20f1c07a57d6ed0118d1d1a067c [FLINK-7283][python] fix 
> PythonPlanBinderTest issues with python paths
>
> It only affects a test so I think we should not cancel the release 
> because of that but update the release notes and the Jira issue.
>
> What do you think?
>
> Regards,
> Timo
>
> Am 15.03.18 um 10:10 schrieb Chesnay Schepler:
>> +1
>>
>> * verified that compilation works
>> * ran a few test examples against a local cluster
>> * src artifact contains no binaries
>> * verified signatures
>>
>> On 14.03.2018 21:49, Ted Yu wrote:
>>> +1
>>>
>>> Ran the following command - passed:
>>>
>>> mvn clean package -Pjdk8
>>>
>>> On Wed, Mar 14, 2018 at 3:26 AM, Tzu-Li (Gordon) Tai 
>>> <tz...@apache.org>
>>> wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> Please review and vote on release candidate #2 for Flink 1.3.3, as
>>>> follows:
>>>> [ ] +1, Approve the release
>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>
>>>> The complete staging area is available for your review, which 
>>>> includes:
>>>> * JIRA release notes [1],
>>>> * the official Apache source release and binary convenience 
>>>> releases to be
>>>> deployed to dist.apache.org [2], which are signed with the key with
>>>> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],
>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>> * source code branch “release-1.3.3-rc2” [5],
>>>> * website pull request listing the new release [6].
>>>> * A complete list of all new commits in release-1.3.3-rc2, since
>>>> release-1.3.2 [7]
>>>>
>>>> This release candidate contains fixes for only the following issues:
>>>> [FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase
>>>> [FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.
>>>> checkpointsMatch()
>>>> [FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in
>>>> infinite loop
>>>> [FLINK-7783] Don’t always remove checkpoints in
>>>> ZooKeeperCompletedCheckpointStore#recover()
>>>>
>>>> Since the last candidate was cancelled only due to incorrect 
>>>> binaries in
>>>> the source artifacts, I think we can also have a shorter voting 
>>>> period for
>>>> RC2.
>>>>
>>>> Please test the release and vote for the release candidate before 
>>>> Thursday
>>>> (March 15th), 7pm CET.
>>>> It is adopted by majority approval, with at least 3 PMC affirmative 
>>>> votes.
>>>>
>>>> Please let me know if you disagree with the shortened voting time.
>>>>
>>>> Thanks,
>>>> Gordon
>>>>
>>>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>>> projectId=12315522&version=12341142
>>>> [2] http://people.apache.org/~tzulitai/flink-1.3.3-rc2/
>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>> [4] 
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1151
>>>> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=
>>>> shortlog;h=refs/heads/release-1.3.3-rc2
>>>> [6] https://github.com/apache/flink-web/pull/104
>>>> [7]
>>>> - 90559b5413455d9d0f2b61c389a60e26e5c87800 [hotfix] Properly delete 
>>>> temp
>>>> flink dir in create_source_release.sh
>>>> - 99c0353a34c09af5bedb73f525f691dd7e78fcdd [hotfix] Ensure pristine
>>>> release in tools/releasing/create_source_release.sh
>>>> - b2437f87e361a822adbad6f1c3e6eb14eeeb09fa [FLINK-8487] Verify 
>>>> ZooKeeper
>>>> checkpoint store behaviour with ITCase
>>>> - 1432092f29c548c55af562ff7b4a7973fedd2e22 [FLINK-8890] Compare
>>>> checkpoints with order in CompletedCheckpoint.checkpointsMatch()
>>>> - df37d7acfea10a5ca3186f3c53294f2050758627 [FLINK-8807] Fix
>>>> ZookeeperCompleted checkpoint store can get stuck in infinite loop
>>>> - f69bdf207b92ca47a5ce3e29f6ec7193ed17ec72 [FLINK-7783] Don’t always
>>>> remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()
>>>>
>>>>
>
>


Re: [VOTE] Release 1.3.3, release candidate #2

Posted by Timo Walther <tw...@apache.org>.
+1

- built and run tests locally
- run some training exercises locally
- looked over the commits

I found one minor thing that should be mentioned. It seems that there is 
one unintended commit in the release:

2455df962c76d20f1c07a57d6ed0118d1d1a067c [FLINK-7283][python] fix 
PythonPlanBinderTest issues with python paths

It only affects a test so I think we should not cancel the release 
because of that but update the release notes and the Jira issue.

What do you think?

Regards,
Timo

Am 15.03.18 um 10:10 schrieb Chesnay Schepler:
> +1
>
> * verified that compilation works
> * ran a few test examples against a local cluster
> * src artifact contains no binaries
> * verified signatures
>
> On 14.03.2018 21:49, Ted Yu wrote:
>> +1
>>
>> Ran the following command - passed:
>>
>> mvn clean package -Pjdk8
>>
>> On Wed, Mar 14, 2018 at 3:26 AM, Tzu-Li (Gordon) Tai 
>> <tz...@apache.org>
>> wrote:
>>
>>> Hi everyone,
>>>
>>> Please review and vote on release candidate #2 for Flink 1.3.3, as
>>> follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release and binary convenience releases 
>>> to be
>>> deployed to dist.apache.org [2], which are signed with the key with
>>> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code branch “release-1.3.3-rc2” [5],
>>> * website pull request listing the new release [6].
>>> * A complete list of all new commits in release-1.3.3-rc2, since
>>> release-1.3.2 [7]
>>>
>>> This release candidate contains fixes for only the following issues:
>>> [FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase
>>> [FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.
>>> checkpointsMatch()
>>> [FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in
>>> infinite loop
>>> [FLINK-7783] Don’t always remove checkpoints in
>>> ZooKeeperCompletedCheckpointStore#recover()
>>>
>>> Since the last candidate was cancelled only due to incorrect 
>>> binaries in
>>> the source artifacts, I think we can also have a shorter voting 
>>> period for
>>> RC2.
>>>
>>> Please test the release and vote for the release candidate before 
>>> Thursday
>>> (March 15th), 7pm CET.
>>> It is adopted by majority approval, with at least 3 PMC affirmative 
>>> votes.
>>>
>>> Please let me know if you disagree with the shortened voting time.
>>>
>>> Thanks,
>>> Gordon
>>>
>>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>> projectId=12315522&version=12341142
>>> [2] http://people.apache.org/~tzulitai/flink-1.3.3-rc2/
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4] 
>>> https://repository.apache.org/content/repositories/orgapacheflink-1151
>>> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=
>>> shortlog;h=refs/heads/release-1.3.3-rc2
>>> [6] https://github.com/apache/flink-web/pull/104
>>> [7]
>>> - 90559b5413455d9d0f2b61c389a60e26e5c87800 [hotfix] Properly delete 
>>> temp
>>> flink dir in create_source_release.sh
>>> - 99c0353a34c09af5bedb73f525f691dd7e78fcdd [hotfix] Ensure pristine
>>> release in tools/releasing/create_source_release.sh
>>> - b2437f87e361a822adbad6f1c3e6eb14eeeb09fa [FLINK-8487] Verify 
>>> ZooKeeper
>>> checkpoint store behaviour with ITCase
>>> - 1432092f29c548c55af562ff7b4a7973fedd2e22 [FLINK-8890] Compare
>>> checkpoints with order in CompletedCheckpoint.checkpointsMatch()
>>> - df37d7acfea10a5ca3186f3c53294f2050758627 [FLINK-8807] Fix
>>> ZookeeperCompleted checkpoint store can get stuck in infinite loop
>>> - f69bdf207b92ca47a5ce3e29f6ec7193ed17ec72 [FLINK-7783] Don’t always
>>> remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()
>>>
>>>


Re: [VOTE] Release 1.3.3, release candidate #2

Posted by Chesnay Schepler <ch...@apache.org>.
+1

* verified that compilation works
* ran a few test examples against a local cluster
* src artifact contains no binaries
* verified signatures

On 14.03.2018 21:49, Ted Yu wrote:
> +1
>
> Ran the following command - passed:
>
> mvn clean package -Pjdk8
>
> On Wed, Mar 14, 2018 at 3:26 AM, Tzu-Li (Gordon) Tai <tz...@apache.org>
> wrote:
>
>> Hi everyone,
>>
>> Please review and vote on release candidate #2 for Flink 1.3.3, as
>> follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release and binary convenience releases to be
>> deployed to dist.apache.org [2], which are signed with the key with
>> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code branch “release-1.3.3-rc2” [5],
>> * website pull request listing the new release [6].
>> * A complete list of all new commits in release-1.3.3-rc2, since
>> release-1.3.2 [7]
>>
>> This release candidate contains fixes for only the following issues:
>> [FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase
>> [FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.
>> checkpointsMatch()
>> [FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in
>> infinite loop
>> [FLINK-7783] Don’t always remove checkpoints in
>> ZooKeeperCompletedCheckpointStore#recover()
>>
>> Since the last candidate was cancelled only due to incorrect binaries in
>> the source artifacts, I think we can also have a shorter voting period for
>> RC2.
>>
>> Please test the release and vote for the release candidate before Thursday
>> (March 15th), 7pm CET.
>> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>>
>> Please let me know if you disagree with the shortened voting time.
>>
>> Thanks,
>> Gordon
>>
>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> projectId=12315522&version=12341142
>> [2] http://people.apache.org/~tzulitai/flink-1.3.3-rc2/
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4] https://repository.apache.org/content/repositories/orgapacheflink-1151
>> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=
>> shortlog;h=refs/heads/release-1.3.3-rc2
>> [6] https://github.com/apache/flink-web/pull/104
>> [7]
>> - 90559b5413455d9d0f2b61c389a60e26e5c87800 [hotfix] Properly delete temp
>> flink dir in create_source_release.sh
>> - 99c0353a34c09af5bedb73f525f691dd7e78fcdd [hotfix] Ensure pristine
>> release in tools/releasing/create_source_release.sh
>> - b2437f87e361a822adbad6f1c3e6eb14eeeb09fa [FLINK-8487] Verify ZooKeeper
>> checkpoint store behaviour with ITCase
>> - 1432092f29c548c55af562ff7b4a7973fedd2e22 [FLINK-8890] Compare
>> checkpoints with order in CompletedCheckpoint.checkpointsMatch()
>> - df37d7acfea10a5ca3186f3c53294f2050758627 [FLINK-8807] Fix
>> ZookeeperCompleted checkpoint store can get stuck in infinite loop
>> - f69bdf207b92ca47a5ce3e29f6ec7193ed17ec72 [FLINK-7783] Don’t always
>> remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()
>>
>>


Re: [VOTE] Release 1.3.3, release candidate #2

Posted by Ted Yu <yu...@gmail.com>.
+1

Ran the following command - passed:

mvn clean package -Pjdk8

On Wed, Mar 14, 2018 at 3:26 AM, Tzu-Li (Gordon) Tai <tz...@apache.org>
wrote:

> Hi everyone,
>
> Please review and vote on release candidate #2 for Flink 1.3.3, as
> follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be
> deployed to dist.apache.org [2], which are signed with the key with
> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code branch “release-1.3.3-rc2” [5],
> * website pull request listing the new release [6].
> * A complete list of all new commits in release-1.3.3-rc2, since
> release-1.3.2 [7]
>
> This release candidate contains fixes for only the following issues:
> [FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase
> [FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.
> checkpointsMatch()
> [FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in
> infinite loop
> [FLINK-7783] Don’t always remove checkpoints in
> ZooKeeperCompletedCheckpointStore#recover()
>
> Since the last candidate was cancelled only due to incorrect binaries in
> the source artifacts, I think we can also have a shorter voting period for
> RC2.
>
> Please test the release and vote for the release candidate before Thursday
> (March 15th), 7pm CET.
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>
> Please let me know if you disagree with the shortened voting time.
>
> Thanks,
> Gordon
>
> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12315522&version=12341142
> [2] http://people.apache.org/~tzulitai/flink-1.3.3-rc2/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1151
> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=
> shortlog;h=refs/heads/release-1.3.3-rc2
> [6] https://github.com/apache/flink-web/pull/104
> [7]
> - 90559b5413455d9d0f2b61c389a60e26e5c87800 [hotfix] Properly delete temp
> flink dir in create_source_release.sh
> - 99c0353a34c09af5bedb73f525f691dd7e78fcdd [hotfix] Ensure pristine
> release in tools/releasing/create_source_release.sh
> - b2437f87e361a822adbad6f1c3e6eb14eeeb09fa [FLINK-8487] Verify ZooKeeper
> checkpoint store behaviour with ITCase
> - 1432092f29c548c55af562ff7b4a7973fedd2e22 [FLINK-8890] Compare
> checkpoints with order in CompletedCheckpoint.checkpointsMatch()
> - df37d7acfea10a5ca3186f3c53294f2050758627 [FLINK-8807] Fix
> ZookeeperCompleted checkpoint store can get stuck in infinite loop
> - f69bdf207b92ca47a5ce3e29f6ec7193ed17ec72 [FLINK-7783] Don’t always
> remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()
>
>

Re: [RESULT] [VOTE] Release 1.3.3, release candidate #2

Posted by Tzu-Li Tai <tz...@gmail.com>.
The voting time has passed and I'm happy to announce that we've collected 
enough votes to release this RC as Flink 1.3.3. 

+1 votes: 
- Ted (non-binding) 
- Timo (binding) 
- Chesnay (binding) 
- Fabian (binding) 
- Gordon (binding)
- Henry (binding) 

That's 6 votes, 5 binding. No 0 or -1 votes. 

I'll modify the JIRA release notes / blog post to include the extra commit.
Once the blog post is published and artifacts are pushed, a separate
announcement will be sent.

Cheers,
Gordon



--
Sent from: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/

Re: [VOTE] Release 1.3.3, release candidate #2

Posted by Henry Saputra <he...@gmail.com>.
Signature file looks good
Hash files look good
LICENSE file exists
NOTICE file exists
Source artifact build and local tests passed

+1



On Wed, Mar 14, 2018 at 3:26 AM, Tzu-Li (Gordon) Tai <tz...@apache.org>
wrote:

> Hi everyone,
>
> Please review and vote on release candidate #2 for Flink 1.3.3, as
> follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be
> deployed to dist.apache.org [2], which are signed with the key with
> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code branch “release-1.3.3-rc2” [5],
> * website pull request listing the new release [6].
> * A complete list of all new commits in release-1.3.3-rc2, since
> release-1.3.2 [7]
>
> This release candidate contains fixes for only the following issues:
> [FLINK-8487] Verify ZooKeeper checkpoint store behaviour with ITCase
> [FLINK-8890] Compare checkpoints with order in CompletedCheckpoint.
> checkpointsMatch()
> [FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in
> infinite loop
> [FLINK-7783] Don’t always remove checkpoints in
> ZooKeeperCompletedCheckpointStore#recover()
>
> Since the last candidate was cancelled only due to incorrect binaries in
> the source artifacts, I think we can also have a shorter voting period for
> RC2.
>
> Please test the release and vote for the release candidate before Thursday
> (March 15th), 7pm CET.
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>
> Please let me know if you disagree with the shortened voting time.
>
> Thanks,
> Gordon
>
> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12315522&version=12341142
> [2] http://people.apache.org/~tzulitai/flink-1.3.3-rc2/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1151
> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=
> shortlog;h=refs/heads/release-1.3.3-rc2
> [6] https://github.com/apache/flink-web/pull/104
> [7]
> - 90559b5413455d9d0f2b61c389a60e26e5c87800 [hotfix] Properly delete temp
> flink dir in create_source_release.sh
> - 99c0353a34c09af5bedb73f525f691dd7e78fcdd [hotfix] Ensure pristine
> release in tools/releasing/create_source_release.sh
> - b2437f87e361a822adbad6f1c3e6eb14eeeb09fa [FLINK-8487] Verify ZooKeeper
> checkpoint store behaviour with ITCase
> - 1432092f29c548c55af562ff7b4a7973fedd2e22 [FLINK-8890] Compare
> checkpoints with order in CompletedCheckpoint.checkpointsMatch()
> - df37d7acfea10a5ca3186f3c53294f2050758627 [FLINK-8807] Fix
> ZookeeperCompleted checkpoint store can get stuck in infinite loop
> - f69bdf207b92ca47a5ce3e29f6ec7193ed17ec72 [FLINK-7783] Don’t always
> remove checkpoints in ZooKeeperCompletedCheckpointStore#recover()
>
>