You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/04/01 09:40:57 UTC
Review Request 32715: HIVE-10178 DateWritable incorrectly calculates
daysSinceEpoch for negative Unix time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32715/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-10178
https://issues.apache.org/jira/browse/HIVE-10178
Repository: hive-git
Description
-------
HIVE-10178 DateWritable incorrectly calculates daysSinceEpoch for negative Unix time
Diffs
-----
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLastDay.java a8428769a86ba04808c1ee1823576018e7f1fc1c
serde/src/java/org/apache/hadoop/hive/serde2/io/DateWritable.java bee23403d68c7e8121128b4cdea98afdf71116eb
Diff: https://reviews.apache.org/r/32715/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 32715: HIVE-10178 DateWritable incorrectly
calculates daysSinceEpoch for negative Unix time
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32715/
-----------------------------------------------------------
(Updated April 1, 2015, 10:01 p.m.)
Review request for hive and Jason Dere.
Changes
-------
regenerate q.out for
--spark
ql/src/test/results/clientpositive/spark/vector_between_in.q.out
--tez
ql/src/test/results/clientpositive/tez/update_all_types.q.out
ql/src/test/results/clientpositive/tez/vector_between_in.q.out
--clientpositive
ql/src/test/results/clientpositive/interval_arithmetic.q.out
ql/src/test/results/clientpositive/update_all_types.q.out
ql/src/test/results/clientpositive/vector_between_in.q.out
Bugs: HIVE-10178
https://issues.apache.org/jira/browse/HIVE-10178
Repository: hive-git
Description
-------
HIVE-10178 DateWritable incorrectly calculates daysSinceEpoch for negative Unix time
Diffs (updated)
-----
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLastDay.java a8428769a86ba04808c1ee1823576018e7f1fc1c
ql/src/test/results/clientpositive/interval_arithmetic.q.out 0eb342c8c1b4a131e13e7d6ce6283b4ff6aa6f3b
ql/src/test/results/clientpositive/spark/vector_between_in.q.out b7de2a155230e8a0943c86f2ed73bff43dd61468
ql/src/test/results/clientpositive/tez/update_all_types.q.out eba4dde4cf60d23bcfbb886ecd72d20bceed766b
ql/src/test/results/clientpositive/tez/vector_between_in.q.out 486f534b12ddee57b6251082317f89db23e80c17
ql/src/test/results/clientpositive/update_all_types.q.out eba4dde4cf60d23bcfbb886ecd72d20bceed766b
ql/src/test/results/clientpositive/vector_between_in.q.out ca488a3c1df9ad6b95f3b48652905c7517349931
serde/src/java/org/apache/hadoop/hive/serde2/io/DateWritable.java bee23403d68c7e8121128b4cdea98afdf71116eb
Diff: https://reviews.apache.org/r/32715/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 32715: HIVE-10178 DateWritable incorrectly
calculates daysSinceEpoch for negative Unix time
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32715/
-----------------------------------------------------------
(Updated April 1, 2015, 8:22 a.m.)
Review request for hive and Jason Dere.
Changes
-------
replaced Math.floor with ((millisUtc - 86399999) / MILLIS_PER_DAY)
Bugs: HIVE-10178
https://issues.apache.org/jira/browse/HIVE-10178
Repository: hive-git
Description
-------
HIVE-10178 DateWritable incorrectly calculates daysSinceEpoch for negative Unix time
Diffs (updated)
-----
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLastDay.java a8428769a86ba04808c1ee1823576018e7f1fc1c
serde/src/java/org/apache/hadoop/hive/serde2/io/DateWritable.java bee23403d68c7e8121128b4cdea98afdf71116eb
Diff: https://reviews.apache.org/r/32715/diff/
Testing
-------
Thanks,
Alexander Pivovarov